Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RunCommandNB pipe issue #155

Merged
merged 5 commits into from
Dec 25, 2018
Merged

Fix RunCommandNB pipe issue #155

merged 5 commits into from
Dec 25, 2018

Conversation

auxten
Copy link
Contributor

@auxten auxten commented Dec 25, 2018

No description provided.

@codecov
Copy link

codecov bot commented Dec 25, 2018

Codecov Report

Merging #155 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #155      +/-   ##
===========================================
- Coverage    76.77%   76.77%   -0.01%     
===========================================
  Files          146      146              
  Lines        10903    10890      -13     
===========================================
- Hits          8371     8361      -10     
+ Misses        1843     1841       -2     
+ Partials       689      688       -1

@codecov
Copy link

codecov bot commented Dec 25, 2018

Codecov Report

Merging #155 into develop will increase coverage by 0.15%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #155      +/-   ##
===========================================
+ Coverage    76.77%   76.93%   +0.15%     
===========================================
  Files          146      146              
  Lines        10903    10895       -8     
===========================================
+ Hits          8371     8382      +11     
+ Misses        1843     1828      -15     
+ Partials       689      685       -4

utils/exec.go Outdated Show resolved Hide resolved
Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@auxten auxten merged commit a448974 into develop Dec 25, 2018
@auxten auxten deleted the bugfix/execPipe branch December 25, 2018 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants