Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP(S) Adapter Improvements and various query sanitizations #157

Merged
merged 14 commits into from
Dec 27, 2018
Merged

HTTP(S) Adapter Improvements and various query sanitizations #157

merged 14 commits into from
Dec 27, 2018

Conversation

xq262144
Copy link
Contributor

  1. Support http/unprivileged mode, easy for testing and POC.
  2. Support prepare statement and parameters in adapter query.
  3. Support application/json content-type request in query.
  4. Various query sanitization, including: sqlite special functions/internal tables/special queries.
  5. Slow query logging support.
  6. LevelDB storage page size adjustment.

@CovenantSQL CovenantSQL deleted a comment from codecov bot Dec 26, 2018
@CovenantSQL CovenantSQL deleted a comment from codecov bot Dec 26, 2018
@codecov
Copy link

codecov bot commented Dec 26, 2018 •
edited
Loading

Codecov Report

Merging #157 into develop will increase coverage by 0.31%.
The diff coverage is 84.96%.

@@             Coverage Diff             @@
##           develop     #157      +/-   ##
===========================================
+ Coverage    76.63%   76.95%   +0.31%     
===========================================
  Files          146      147       +1     
  Lines        10916    11100     +184     
===========================================
+ Hits          8366     8542     +176     
+ Misses        1860     1859       -1     
- Partials       690      699       +9

auxten
auxten reviewed Dec 26, 2018
View reviewed changes
xenomint/query_sanitizer.go Outdated Show resolved Hide resolved
leventeliu
leventeliu approved these changes Dec 26, 2018
View reviewed changes
Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approve.

auxten
auxten approved these changes Dec 27, 2018
View reviewed changes
Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auxten auxten merged commit 4ef9906 into develop Dec 27, 2018
@leventeliu leventeliu deleted the feature/adapterQueryArgs branch December 29, 2018 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auxten auxten auxten approved these changes

@leventeliu leventeliu leventeliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xq262144 @auxten @leventeliu