Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client readme and example #160

Merged
merged 3 commits into from
Dec 26, 2018
Merged

Update client readme and example #160

merged 3 commits into from
Dec 26, 2018

Conversation

laodouya
Copy link
Member

Update client README.md.
Add create dsn and drop dsn in simple example.

@codecov
Copy link

codecov bot commented Dec 26, 2018

Codecov Report

Merging #160 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #160      +/-   ##
===========================================
+ Coverage    76.66%   76.67%   +<.01%     
===========================================
  Files          146      146              
  Lines        10920    10920              
===========================================
+ Hits          8372     8373       +1     
+ Misses        1859     1858       -1     
  Partials       689      689

@codecov
Copy link

codecov bot commented Dec 26, 2018

Codecov Report

Merging #160 into develop will increase coverage by 0.31%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #160      +/-   ##
===========================================
+ Coverage    76.57%   76.88%   +0.31%     
===========================================
  Files          146      146              
  Lines        10916    10916              
===========================================
+ Hits          8359     8393      +34     
+ Misses        1869     1838      -31     
+ Partials       688      685       -3

Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xq262144 xq262144 merged commit a60b261 into develop Dec 26, 2018
@laodouya laodouya deleted the feature/clientReadme branch December 28, 2018 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants