Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract observer to an independent docker image #163

Merged
merged 17 commits into from
Jan 2, 2019

Conversation

laodouya
Copy link
Member

@laodouya laodouya commented Dec 27, 2018

  1. observer image is now base on covenantsql/explorer image
  2. refactor build.sh, move to makefile

Now use make instead of build.sh. And use make use_all_cores for building in full cpu cores.

@laodouya laodouya force-pushed the feature/independentObserver branch 2 times, most recently from 9aa4cb4 to 342a27d Compare December 29, 2018 03:16
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
bin/docker-entry.sh Outdated Show resolved Hide resolved
@CovenantSQL CovenantSQL deleted a comment from codecov bot Dec 29, 2018
@CovenantSQL CovenantSQL deleted a comment from codecov bot Dec 29, 2018
@CovenantSQL CovenantSQL deleted a comment from codecov bot Dec 29, 2018
@CovenantSQL CovenantSQL deleted a comment from codecov bot Dec 29, 2018
@CovenantSQL CovenantSQL deleted a comment from codecov bot Dec 29, 2018
@CovenantSQL CovenantSQL deleted a comment from codecov bot Dec 29, 2018
@CovenantSQL CovenantSQL deleted a comment from codecov bot Dec 29, 2018
@CovenantSQL CovenantSQL deleted a comment from codecov bot Dec 29, 2018
@CovenantSQL CovenantSQL deleted a comment from codecov bot Dec 29, 2018
@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #163 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #163      +/-   ##
===========================================
+ Coverage    75.72%   75.72%   +<.01%     
===========================================
  Files          135      135              
  Lines        10946    10947       +1     
===========================================
+ Hits          8289     8290       +1     
+ Misses        2011     2008       -3     
- Partials       646      649       +3

@CovenantSQL CovenantSQL deleted a comment from codecov bot Dec 29, 2018
Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@leventeliu leventeliu merged commit 95d8718 into develop Jan 2, 2019
@laodouya laodouya deleted the feature/independentObserver branch January 2, 2019 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants