-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JSON RPC API #164
Support JSON RPC API #164
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #164 +/- ##
===========================================
- Coverage 72.23% 71.15% -1.08%
===========================================
Files 177 177
Lines 14293 13937 -356
===========================================
- Hits 10324 9917 -407
- Misses 2655 2744 +89
+ Partials 1314 1276 -38 |
Codecov Report
@@ Coverage Diff @@
## develop #164 +/- ##
===========================================
+ Coverage 76.07% 77.55% +1.47%
===========================================
Files 139 150 +11
Lines 11500 11914 +414
===========================================
+ Hits 8749 9240 +491
+ Misses 2080 1976 -104
- Partials 671 698 +27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
1. add StopServersAndWait to Service instance; 2. export api.models.OpenSQLiteDBAsGorp function for convenient use; 3. update cqld's bootstrap.
1. refactor bp_getTransactionList to support pagination; 2. add new API: bp_getTransactionListOfBlock.
1. remove mode flag from cqld command; 2. type define bp.RunMode, don't use string representation; 3. move registerNodeToBP to rpcutils.go; 4. remove redundant calls to registerNodeToBP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Support JSON RPC API