Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSON RPC API #164

Merged
merged 63 commits into from
Jan 23, 2019
Merged

Support JSON RPC API #164

merged 63 commits into from
Jan 23, 2019

Conversation

ggicci
Copy link
Contributor

@ggicci ggicci commented Dec 29, 2018

Support JSON RPC API

@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #164 into develop will decrease coverage by 1.07%.
The diff coverage is 11.94%.

@@             Coverage Diff             @@
##           develop     #164      +/-   ##
===========================================
- Coverage    72.23%   71.15%   -1.08%     
===========================================
  Files          177      177              
  Lines        14293    13937     -356     
===========================================
- Hits         10324     9917     -407     
- Misses        2655     2744      +89     
+ Partials      1314     1276      -38

@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #164 into develop will increase coverage by 1.47%.
The diff coverage is 77.62%.

@@             Coverage Diff             @@
##           develop     #164      +/-   ##
===========================================
+ Coverage    76.07%   77.55%   +1.47%     
===========================================
  Files          139      150      +11     
  Lines        11500    11914     +414     
===========================================
+ Hits          8749     9240     +491     
+ Misses        2080     1976     -104     
- Partials       671      698      +27

@ggicci ggicci changed the title Feature/jsonrpc Support JSON RPC API Jan 3, 2019
@xq262144 xq262144 changed the title Support JSON RPC API [WIP] Support JSON RPC API Jan 3, 2019
Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ggicci ggicci changed the title [WIP] Support JSON RPC API Support JSON RPC API Jan 22, 2019
cmd/cqld/bootstrap.go Outdated Show resolved Hide resolved
cmd/cqld/main.go Outdated Show resolved Hide resolved
cmd/cqld/main.go Outdated Show resolved Hide resolved
1. remove mode flag from cqld command;
2. type define bp.RunMode, don't use string representation;
3. move registerNodeToBP to rpcutils.go;
4. remove redundant calls to registerNodeToBP.
Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggicci ggicci merged commit 6eda4b5 into develop Jan 23, 2019
@ggicci ggicci deleted the feature/jsonrpc branch January 23, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants