-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update observer api to support queries pagination #167
Conversation
552aa76
to
31f60c3
Compare
Codecov Report
@@ Coverage Diff @@
## develop #167 +/- ##
===========================================
- Coverage 75.51% 75.33% -0.18%
===========================================
Files 135 135
Lines 10931 10931
===========================================
- Hits 8254 8235 -19
- Misses 2043 2058 +15
- Partials 634 638 +4 |
Codecov Report
@@ Coverage Diff @@
## develop #167 +/- ##
========================================
Coverage 75.72% 75.72%
========================================
Files 135 135
Lines 10946 10946
========================================
Hits 8289 8289
- Misses 2009 2011 +2
+ Partials 648 646 -2 |
Codecov Report
@@ Coverage Diff @@
## develop #167 +/- ##
===========================================
- Coverage 75.79% 75.72% -0.08%
===========================================
Files 135 135
Lines 10946 10946
===========================================
- Hits 8297 8289 -8
- Misses 2004 2011 +7
- Partials 645 646 +1 |
Codecov Report
@@ Coverage Diff @@
## develop #167 +/- ##
===========================================
- Coverage 75.79% 75.76% -0.04%
===========================================
Files 135 135
Lines 10946 10946
===========================================
- Hits 8297 8293 -4
- Misses 2004 2008 +4
Partials 645 645 |
Codecov Report
@@ Coverage Diff @@
## develop #167 +/- ##
===========================================
- Coverage 75.79% 75.76% -0.04%
===========================================
Files 135 135
Lines 10946 10946
===========================================
- Hits 8297 8293 -4
- Misses 2004 2008 +4
Partials 645 645 |
Codecov Report
@@ Coverage Diff @@
## develop #167 +/- ##
===========================================
+ Coverage 75.79% 75.94% +0.14%
===========================================
Files 135 135
Lines 10946 10946
===========================================
+ Hits 8297 8313 +16
+ Misses 2004 1988 -16
Partials 645 645 |
Codecov Report
@@ Coverage Diff @@
## develop #167 +/- ##
===========================================
+ Coverage 75.79% 75.94% +0.14%
===========================================
Files 135 135
Lines 10946 10946
===========================================
+ Hits 8297 8313 +16
+ Misses 2004 1988 -16
Partials 645 645 |
Codecov Report
@@ Coverage Diff @@
## develop #167 +/- ##
===========================================
+ Coverage 75.79% 75.85% +0.05%
===========================================
Files 135 135
Lines 10946 10946
===========================================
+ Hits 8297 8303 +6
+ Misses 2004 1999 -5
+ Partials 645 644 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Update observer api, add pagination support.