Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix miner crash on billing #169

Merged
merged 3 commits into from
Dec 29, 2018
Merged

Fix miner crash on billing #169

merged 3 commits into from
Dec 29, 2018

Conversation

leventeliu
Copy link
Contributor

  • Adjust block cache TTL
  • Add codes to pull non-cached block

xq262144
xq262144 approved these changes Dec 29, 2018
View reviewed changes
Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #169 into develop will decrease coverage by <.01%.
The diff coverage is 73.68%.

@@             Coverage Diff             @@
##           develop     #169      +/-   ##
===========================================
- Coverage    75.61%   75.61%   -0.01%     
===========================================
  Files          135      135              
  Lines        10931    10946      +15     
===========================================
+ Hits          8266     8277      +11     
- Misses        2017     2020       +3     
- Partials       648      649       +1

1 similar comment
@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #169 into develop will decrease coverage by <.01%.
The diff coverage is 73.68%.

@@             Coverage Diff             @@
##           develop     #169      +/-   ##
===========================================
- Coverage    75.61%   75.61%   -0.01%     
===========================================
  Files          135      135              
  Lines        10931    10946      +15     
===========================================
+ Hits          8266     8277      +11     
- Misses        2017     2020       +3     
- Partials       648      649       +1

zeqing-guo
zeqing-guo approved these changes Dec 29, 2018
View reviewed changes
Copy link
Contributor

@zeqing-guo zeqing-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeqing-guo zeqing-guo merged commit b65cc1a into develop Dec 29, 2018
@laodouya laodouya deleted the bugfix/sqlchain branch February 28, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xq262144 xq262144 xq262144 approved these changes

@zeqing-guo zeqing-guo zeqing-guo approved these changes

@auxten auxten Awaiting requested review from auxten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leventeliu @xq262144 @zeqing-guo