Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permission granting/revoking #172

Merged
merged 50 commits into from
Jan 4, 2019
Merged

Add permission granting/revoking #172

merged 50 commits into from
Jan 4, 2019

Conversation

leventeliu
Copy link
Contributor

No description provided.

covenantdb
covenantdb reviewed Dec 29, 2018
View reviewed changes
blockproducer/metastate.go Outdated Show resolved Hide resolved
worker/chainbusservice.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 29, 2018 •
edited
Loading

Codecov Report

Merging #172 into develop will decrease coverage by 0.22%.
The diff coverage is 51.35%.

@@             Coverage Diff             @@
##           develop     #172      +/-   ##
===========================================
- Coverage    77.04%   76.82%   -0.23%     
===========================================
  Files          135      134       -1     
  Lines        10853    10974     +121     
===========================================
+ Hits          8362     8431      +69     
- Misses        1845     1902      +57     
+ Partials       646      641       -5

@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #172 into develop will increase coverage by 0.86%.
The diff coverage is 75.33%.

@@             Coverage Diff             @@
##           develop     #172      +/-   ##
===========================================
+ Coverage    75.83%   76.69%   +0.86%     
===========================================
  Files          135      134       -1     
  Lines        10946    10978      +32     
===========================================
+ Hits          8301     8420     +119     
+ Misses        2001     1908      -93     
- Partials       644      650       +6

xq262144
xq262144 reviewed Jan 4, 2019
View reviewed changes
types/token.go Outdated Show resolved Hide resolved
xq262144
xq262144 reviewed Jan 4, 2019
View reviewed changes
types/token.go Outdated Show resolved Hide resolved
xq262144
xq262144 reviewed Jan 4, 2019
View reviewed changes
worker/dbms.go Outdated Show resolved Hide resolved
@zeqing-guo zeqing-guo changed the title Add permission control Add permission granting/revoking Jan 4, 2019
auxten
auxten reviewed Jan 4, 2019
View reviewed changes
blockproducer/metastate.go Outdated Show resolved Hide resolved
xq262144
xq262144 approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

auxten
auxten approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auxten auxten merged commit 619a9c7 into develop Jan 4, 2019
@zeqing-guo zeqing-guo deleted the feature/chainBus-SQLChain branch January 4, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@covenantdb covenantdb covenantdb left review comments

@auxten auxten auxten approved these changes

@xq262144 xq262144 xq262144 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@leventeliu @auxten @xq262144 @covenantdb @zeqing-guo