Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune unused codes #174

Merged
merged 4 commits into from
Jan 2, 2019
Merged

Prune unused codes #174

merged 4 commits into from
Jan 2, 2019

Conversation

leventeliu
Copy link
Contributor

@leventeliu leventeliu commented Dec 29, 2018

Powered by honnef.co/go/tools/cmd/unused

$ unused -exported "github.com/CovenantSQL/CovenantSQL/..."
blockproducer/chain_service.go:111:17: func (*Chain).loadAccountCovenantBalance is unused (U1000)
blockproducer/chain_service.go:117:17: func (*Chain).loadAccountStableBalance is unused (U1000)
blockproducer/chain_service.go:123:17: func (*Chain).loadSQLChainProfile is unused (U1000)
blockproducer/chain_service.go:134:17: func (*Chain).loadSQLChainProfiles is unused (U1000)
blockproducer/config.go:28:2: const blockVersion is unused (U1000)
blockproducer/errors.go:25:2: var ErrDatabaseAllocation is unused (U1000)
blockproducer/errors.go:27:2: var ErrMetricNotCollected is unused (U1000)
blockproducer/errors.go:32:2: var ErrCorruptedIndex is unused (U1000)
blockproducer/errors.go:46:2: var ErrNoSuchTxBilling is unused (U1000)
blockproducer/errors.go:48:2: var ErrSmallerSequenceID is unused (U1000)
blockproducer/errors.go:50:2: var ErrInvalidBillingRequest is unused (U1000)
blockproducer/errors.go:67:2: var ErrDatabaseCannotCreate is unused (U1000)
blockproducer/errors.go:74:2: var ErrTransactionMismatch is unused (U1000)
blockproducer/errors.go:76:2: var ErrMetaStateNotFound is unused (U1000)
blockproducer/metastate.go:193:21: func (*metaState).loadOrStoreProviderObject is unused (U1000)
blockproducer/metastate.go:374:21: func (*metaState).transferAccountStableBalance is unused (U1000)
blockproducer/rpc.go:42:27: func (*ChainRPCService).AdviseNewBlock is unused (U1000)
blockproducer/rpc.go:48:27: func (*ChainRPCService).FetchBlock is unused (U1000)
blockproducer/rpc.go:60:27: func (*ChainRPCService).FetchLastIrreversibleBlock is unused (U1000)
blockproducer/rpc.go:74:27: func (*ChainRPCService).FetchBlockByCount is unused (U1000)
blockproducer/rpc.go:86:27: func (*ChainRPCService).FetchTxBilling is unused (U1000)
blockproducer/rpc.go:91:27: func (*ChainRPCService).NextAccountNonce is unused (U1000)
blockproducer/rpc.go:102:27: func (*ChainRPCService).AddTx is unused (U1000)
blockproducer/rpc.go:113:27: func (*ChainRPCService).QueryAccountStableBalance is unused (U1000)
blockproducer/rpc.go:122:27: func (*ChainRPCService).QueryAccountCovenantBalance is unused (U1000)
blockproducer/rpc.go:131:27: func (*ChainRPCService).QuerySQLChainProfile is unused (U1000)
blockproducer/rpc.go:143:27: func (*ChainRPCService).Sub is unused (U1000)
blockproducer/xxx_test.go:43:2: var uuidLen is unused (U1000)
blockproducer/xxx_test.go:44:2: var peerNum is unused (U1000)
blockproducer/xxx_test.go:46:2: var testAddress1 is unused (U1000)
blockproducer/xxx_test.go:47:2: var testAddress2 is unused (U1000)
blockproducer/xxx_test.go:48:2: var testInitBalance is unused (U1000)
blockproducer/xxx_test.go:49:2: var testDifficulty is unused (U1000)
blockproducer/xxx_test.go:51:2: var testAddress1Nonce is unused (U1000)
blockproducer/xxx_test.go:53:2: var testingTraceFile is unused (U1000)
blockproducer/xxx_test.go:62:2: var testingMasterKey is unused (U1000)
blockproducer/xxx_test.go:66:2: const letterBytes is unused (U1000)
blockproducer/xxx_test.go:69:6: func generateRandomBytes is unused (U1000)
blockproducer/xxx_test.go:77:6: func generateRandomDatabaseID is unused (U1000)
blockproducer/xxx_test.go:82:6: func generateRandomDatabaseIDs is unused (U1000)
blockproducer/xxx_test.go:90:6: func randStringBytes is unused (U1000)
blockproducer/xxx_test.go:98:6: func generateRandomBlock is unused (U1000)
blockproducer/xxx_test.go:157:6: func generateRandomBlockWithTransactions is unused (U1000)
blockproducer/xxx_test.go:202:6: func generateRandomBillingRequestHeader is unused (U1000)
blockproducer/xxx_test.go:213:6: func generateRandomBillingRequest is unused (U1000)
blockproducer/xxx_test.go:245:6: func generateRandomBillingHeader is unused (U1000)
blockproducer/xxx_test.go:276:6: func generateRandomBillingAndBaseAccount is unused (U1000)
blockproducer/xxx_test.go:304:6: func generateRandomAccountBilling is unused (U1000)
blockproducer/xxx_test.go:321:6: func generateRandomGasAmount is unused (U1000)
blockproducer/xxx_test.go:335:6: func generateRandomHash is unused (U1000)
blockproducer/xxx_test.go:341:6: func registerNodesWithPublicKey is unused (U1000)
blockproducer/xxx_test.go:379:6: func createRandomString is unused (U1000)
blockproducer/xxx_test.go:385:6: func createTestPeersWithPrivKeys is unused (U1000)
blockproducer/xxx_test.go:421:6: func createTestPeers is unused (U1000)
client/clientbench_test.go:33:2: var logDir is unused (U1000)
client/helper_test.go:61:25: func (*stubBPService).QueryAccountStableBalance is unused (U1000)
client/helper_test.go:66:25: func (*stubBPService).QueryAccountCovenantBalance is unused (U1000)
client/helper_test.go:71:25: func (*stubBPService).QuerySQLChainProfile is unused (U1000)
client/helper_test.go:87:25: func (*stubBPService).NextAccountNonce is unused (U1000)
client/helper_test.go:93:25: func (*stubBPService).AddTx is unused (U1000)
cmd/cql-adapter/config/errors.go:25:2: var ErrRequireServerCertificate is unused (U1000)
cmd/cql-adapter/server.go:32:2: field tlsConfig is unused (U1000)
cmd/cql-minerd/integration_test.go:59:2: var testInitTokenAmount is unused (U1000)
cmd/cql-minerd/integration_test.go:902:6: func getNonce is unused (U1000)
cmd/cql-observer/service.go:223:19: func (*Service).AdviseNewBlock is unused (U1000)
cmd/cqld/adapter.go:297:25: func (*KayakKVServer).GetDatabase is unused (U1000)
cmd/cqld/adapter.go:330:25: func (*KayakKVServer).SetDatabase is unused (U1000)
cmd/cqld/adapter.go:350:25: func (*KayakKVServer).DeleteDatabase is unused (U1000)
cmd/cqld/adapter.go:373:25: func (*KayakKVServer).GetAllDatabases is unused (U1000)
cmd/cqld/kayak.go:42:24: func (*KayakService).Call is unused (U1000)
cmd/cqld/main.go:58:2: var genKeyPair is unused (U1000)
conf/config.go:34:2: const MinerBuildTag is unused (U1000)
conf/config.go:36:2: const ClientBuildTag is unused (U1000)
conf/parameters.go:23:2: const BPPeriod is unused (U1000)
conf/parameters.go:25:2: const BPTick is unused (U1000)
conf/parameters.go:27:2: const SQLChainPeriod is unused (U1000)
conf/parameters.go:29:2: const SQLChainTick is unused (U1000)
conf/parameters.go:31:2: const SQLChainTTL is unused (U1000)
crypto/asymmetric/signature.go:35:2: var mu is unused (U1000)
crypto/kms/privatekeystore.go:41:2: var ErrInvalidBase58Checksum is unused (U1000)
crypto/kms/pubkeystore.go:105:2: var ErrNotValidNodeID is unused (U1000)
crypto/verifier/common.go:34:6: type HashSignVerifier is unused (U1000)
crypto/verifier/common.go:35:2: func HashSignVerifier.Hash is unused (U1000)
crypto/verifier/common.go:36:2: func HashSignVerifier.Sign is unused (U1000)
crypto/verifier/common.go:37:2: func HashSignVerifier.Verify is unused (U1000)
kayak/types/errors.go:35:2: var ErrNeedRecovery is unused (U1000)
kayak/wal/leveldb_wal.go:194:22: func (*LevelDBWal).GetDB is unused (U1000)
metric/meminfo_numa_linux.go:17:2: const memInfoNumaSubsystem is unused (U1000)
metric/meminfo_numa_linux.go:20:5: var meminfoNodeRE is unused (U1000)
metric/meminfo_numa_linux.go:29:6: type meminfoNumaCollector is unused (U1000)
metric/metric.go:29:2: const KB is unused (U1000)
metric/metric.go:31:2: const MB is unused (U1000)
metric/metric.go:33:2: const GB is unused (U1000)
metric/metric.go:35:2: const TB is unused (U1000)
metric/metric.go:37:2: const PB is unused (U1000)
metric/metric.go:39:2: const EB is unused (U1000)
metric/metric.go:41:2: const ZB is unused (U1000)
route/bootstrap.go:46:7: const TestBPDomain is unused (U1000)
rpc/client_test.go:29:7: const privateKey is unused (U1000)
rpc/client_test.go:31:7: const pass is unused (U1000)
rpc/pool.go:29:6: type SessPool is unused (U1000)
rpc/pool.go:30:2: func SessPool.Get is unused (U1000)
rpc/pool.go:31:2: func SessPool.Set is unused (U1000)
rpc/pool.go:32:2: func SessPool.Remove is unused (U1000)
rpc/pool.go:33:2: func SessPool.Close is unused (U1000)
rpc/pool.go:34:2: func SessPool.Len is unused (U1000)
rpc/rpcutil_test.go:40:2: const DHTStorePath is unused (U1000)
rpc/server_test.go:61:23: func (*TestService).IncCounter is unused (U1000)
rpc/server_test.go:71:23: func (*TestService).IncCounterSimpleArgs is unused (U1000)
sqlchain/chain.go:55:2: var metaRequestIndex is unused (U1000)
sqlchain/chain.go:83:6: func keyToHeight is unused (U1000)
sqlchain/chain.go:1112:17: func (*Chain).getBilling is unused (U1000)
sqlchain/chain.go:1203:17: func (*Chain).collectBillingSignatures is unused (U1000)
sqlchain/chain.go:1294:17: func (*Chain).LaunchBilling is unused (U1000)
sqlchain/chain.go:1319:17: func (*Chain).SignBilling is unused (U1000)
sqlchain/errors.go:26:2: var ErrFieldConversion is unused (U1000)
sqlchain/errors.go:31:2: var ErrFieldLength is unused (U1000)
sqlchain/errors.go:35:2: var ErrNilValue is unused (U1000)
sqlchain/errors.go:41:2: var ErrBlockExists is unused (U1000)
sqlchain/errors.go:48:2: var ErrBlockTimestampOutOfPeriod is unused (U1000)
sqlchain/errors.go:52:2: var ErrMultipleAckOfResponse is unused (U1000)
sqlchain/errors.go:62:2: var ErrQueryNotCached is unused (U1000)
sqlchain/errors.go:66:2: var ErrQuerySignedByAnotherBlock is unused (U1000)
sqlchain/errors.go:69:2: var ErrCorruptedIndex is unused (U1000)
sqlchain/errors.go:72:2: var ErrUnknownMuxRequest is unused (U1000)
sqlchain/errors.go:81:2: var ErrUnavailableBillingRang is unused (U1000)
sqlchain/errors.go:85:2: var ErrHashNotMatch is unused (U1000)
sqlchain/errors.go:88:2: var ErrMetaStateNotFound is unused (U1000)
sqlchain/errors.go:91:2: var ErrAckQueryNotFound is unused (U1000)
sqlchain/errors.go:97:2: var ErrInvalidRequest is unused (U1000)
sqlchain/errors.go:104:2: var ErrInvalidTransactionType is unused (U1000)
sqlchain/mux.go:65:6: type MuxAdviseBinLogReq is unused (U1000)
sqlchain/mux.go:72:6: type MuxAdviseBinLogResp is unused (U1000)
sqlchain/mux.go:79:6: type MuxAdviseAckedQueryReq is unused (U1000)
sqlchain/mux.go:86:6: type MuxAdviseAckedQueryResp is unused (U1000)
sqlchain/mux.go:107:6: type MuxSignBillingReq is unused (U1000)
sqlchain/mux.go:114:6: type MuxSignBillingResp is unused (U1000)
sqlchain/mux.go:121:6: type MuxLaunchBillingReq is unused (U1000)
sqlchain/mux.go:128:6: type MuxLaunchBillingResp is unused (U1000)
sqlchain/mux.go:163:22: func (*MuxService).AdviseNewBlock is unused (U1000)
sqlchain/mux.go:174:22: func (*MuxService).AdviseBinLog is unused (U1000)
sqlchain/mux.go:185:22: func (*MuxService).AdviseAckedQuery is unused (U1000)
sqlchain/mux.go:198:22: func (*MuxService).FetchBlock is unused (U1000)
sqlchain/mux.go:209:22: func (*MuxService).SignBilling is unused (U1000)
sqlchain/mux.go:220:22: func (*MuxService).LaunchBilling is unused (U1000)
sqlchain/mux.go:233:22: func (*MuxService).SubscribeTransactions is unused (U1000)
sqlchain/mux.go:245:22: func (*MuxService).CancelSubscription is unused (U1000)
sqlchain/rpc.go:42:6: type AdviseBinLogReq is unused (U1000)
sqlchain/rpc.go:46:6: type AdviseBinLogResp is unused (U1000)
sqlchain/rpc.go:50:6: type AdviseAckedQueryReq is unused (U1000)
sqlchain/rpc.go:55:6: type AdviseAckedQueryResp is unused (U1000)
sqlchain/rpc.go:70:6: type SignBillingReq is unused (U1000)
sqlchain/rpc.go:75:6: type SignBillingResp is unused (U1000)
sqlchain/rpc.go:82:6: type LaunchBillingReq is unused (U1000)
sqlchain/rpc.go:87:6: type LaunchBillingResp is unused (U1000)
sqlchain/rpc.go:109:27: func (*ChainRPCService).AdviseNewBlock is unused (U1000)
sqlchain/rpc.go:116:27: func (*ChainRPCService).AdviseBinLog is unused (U1000)
sqlchain/rpc.go:122:27: func (*ChainRPCService).AdviseAckedQuery is unused (U1000)
sqlchain/rpc.go:128:27: func (*ChainRPCService).FetchBlock is unused (U1000)
sqlchain/rpc.go:135:27: func (*ChainRPCService).SignBilling is unused (U1000)
sqlchain/rpc.go:142:27: func (*ChainRPCService).LaunchBilling is unused (U1000)
sqlchain/rpc.go:147:27: func (*ChainRPCService).SubscribeTransactions is unused (U1000)
sqlchain/rpc.go:152:27: func (*ChainRPCService).CancelSubscription is unused (U1000)
sqlchain/runtime.go:77:2: field forks is unused (U1000)
sqlchain/runtime.go:176:19: func (*runtime).updateTime is unused (U1000)
sqlchain/runtime.go:210:19: func (*runtime).getQueryGas is unused (U1000)
sqlchain/runtime.go:262:19: func (*runtime).getIndex is unused (U1000)
sqlchain/runtime.go:268:19: func (*runtime).getTotal is unused (U1000)
sqlchain/xxx_test.go:75:6: func newRandomNodes is unused (U1000)
sqlchain/xxx_test.go:189:6: func createRandomQueryResponseWithRequest is unused (U1000)
sqlchain/xxx_test.go:244:6: func createRandomQueryAck is unused (U1000)
sqlchain/xxx_test.go:269:6: func createRandomNodesAndAck is unused (U1000)
sqlchain/xxx_test.go:375:6: func createRandomQueries is unused (U1000)
sqlchain/xxx_test.go:388:6: func createRandomBlockWithQueries is unused (U1000)
test/GNTE/GNTE/main.go:13:6: type tcParams is unused (U1000)
test/GNTE/GNTE/main.go:199:6: func printRules is unused (U1000)
twopc/twopc.go:62:6: func NewOptions is unused (U1000)
twopc/twopc.go:69:6: func NewOptionsWithCallback is unused (U1000)
twopc/twopc_test.go:40:2: const Prepared is unused (U1000)
twopc/twopc_test.go:41:2: const Committed is unused (U1000)
twopc/twopc_test.go:42:2: const RolledBack is unused (U1000)
twopc/twopc_test.go:63:2: field mu is unused (U1000)
twopc/twopc_test.go:71:2: field conn is unused (U1000)
twopc/twopc_test.go:72:2: field client is unused (U1000)
twopc/twopc_test.go:155:29: func (*RaftNodeRPCServer).RPCPrepare is unused (U1000)
twopc/twopc_test.go:176:29: func (*RaftNodeRPCServer).RPCCommit is unused (U1000)
twopc/twopc_test.go:208:29: func (*RaftNodeRPCServer).RPCRollback is unused (U1000)
types/account.go:31:2: const Miner is unused (U1000)
types/account.go:33:2: const Customer is unused (U1000)
types/account.go:35:2: const NumberOfRoles is unused (U1000)
types/account.go:43:2: const UnknownPerm is unused (U1000)
types/account.go:65:27: func (*UserPermission).CheckAdmin is unused (U1000)
types/account.go:82:2: const Arbitration is unused (U1000)
types/account.go:84:2: const NumberOfStatus is unused (U1000)
types/ack_type.go:87:28: func (*SignedAckHeader).ResponseHash is unused (U1000)
types/billing_req.go:24:6: type AdviseBillingReq is unused (U1000)
types/billing_req.go:30:6: type AdviseBillingResp is unused (U1000)
types/bp_block.go:125:19: func (*BPBlock).Producer is unused (U1000)
types/bprpc.go:36:6: type AdviseTxBillingReq is unused (U1000)
types/bprpc.go:42:6: type AdviseTxBillingResp is unused (U1000)
types/bprpc.go:82:6: type FetchTxBillingReq is unused (U1000)
types/bprpc.go:87:6: type FetchTxBillingResp is unused (U1000)
types/bprpc.go:116:6: type SubReq is unused (U1000)
types/bprpc.go:123:6: type SubResp is unused (U1000)
types/bprpc.go:129:6: type OrderMakerReq is unused (U1000)
types/bprpc.go:134:6: type OrderTakerReq is unused (U1000)
types/bprpc.go:140:6: type OrderTakerResp is unused (U1000)
types/chainstate.go:69:22: func (*UserState).AddStatus is unused (U1000)
types/errors.go:30:2: var ErrSignRequest is unused (U1000)
types/errors.go:38:2: var ErrNotExists is unused (U1000)
types/errors.go:40:2: var ErrNoSuchUser is unused (U1000)
types/errors.go:42:2: var ErrOverflow is unused (U1000)
types/errors.go:44:2: var ErrInvalidHeight is unused (U1000)
types/issuekeys.go:55:6: func NewIssueKeys is unused (U1000)
types/updatepermission.go:50:6: func NewUpdatePermission is unused (U1000)
types/xxx_test.go:46:6: func generateRandomSQLChainUser is unused (U1000)
types/xxx_test.go:54:6: func generateRandomSQLChainUsers is unused (U1000)
types/xxx_test.go:64:6: func generateRandomAccountAddresses is unused (U1000)
types/xxx_test.go:74:6: func generateRandomProfile is unused (U1000)
types/xxx_test.go:83:6: func generateRandomAccount is unused (U1000)
types/xxx_test.go:92:6: func generateRandomBytes is unused (U1000)
types/xxx_test.go:114:6: func generateRandomDatabaseIDs is unused (U1000)
types/xxx_test.go:389:6: func createRandomString is unused (U1000)
types/xxx_test.go:395:6: func createRandomStrings is unused (U1000)
utils/big.go:30:2: var tt63 is unused (U1000)
utils/big.go:31:2: var MaxBig256 is unused (U1000)
utils/big.go:32:2: var MaxBig63 is unused (U1000)
utils/errors.go:7:2: var ErrInvalidType is unused (U1000)
utils/integer.go:26:2: const MaxInt8 is unused (U1000)
utils/integer.go:27:2: const MinInt8 is unused (U1000)
utils/integer.go:28:2: const MaxInt16 is unused (U1000)
utils/integer.go:29:2: const MinInt16 is unused (U1000)
utils/integer.go:30:2: const MaxInt32 is unused (U1000)
utils/integer.go:31:2: const MinInt32 is unused (U1000)
utils/integer.go:32:2: const MaxInt64 is unused (U1000)
utils/integer.go:33:2: const MinInt64 is unused (U1000)
utils/integer.go:34:2: const MaxUint8 is unused (U1000)
utils/integer.go:35:2: const MaxUint16 is unused (U1000)
utils/integer.go:36:2: const MaxUint32 is unused (U1000)
utils/log/logwrapper.go:33:2: const PanicLevel is unused (U1000)
utils/log/logwrapper.go:39:2: const ErrorLevel is unused (U1000)
utils/log/logwrapper.go:41:2: const WarnLevel is unused (U1000)
utils/log/logwrapper.go:184:6: func SetFormatter is unused (U1000)
utils/msgpack.go:48:6: func DecodeMsgPackPlain is unused (U1000)
worker/dbms.go:472:19: func (*DBMS).Update is unused (U1000)
worker/dbms.go:485:19: func (*DBMS).Query is unused (U1000)
worker/dbms.go:509:19: func (*DBMS).Ack is unused (U1000)
worker/dbms_mux.go:59:29: func (*DBKayakMuxService).Call is unused (U1000)
worker/dbms_rpc.go:36:6: type SubscribeTransactionsReq is unused (U1000)
worker/dbms_rpc.go:43:6: type SubscribeTransactionsResp is unused (U1000)
worker/dbms_rpc.go:47:6: type CancelSubscriptionReq is unused (U1000)
worker/dbms_rpc.go:53:6: type CancelSubscriptionResp is unused (U1000)
worker/dbms_rpc.go:76:28: func (*DBMSRPCService).Query is unused (U1000)
worker/dbms_rpc.go:107:28: func (*DBMSRPCService).Ack is unused (U1000)
worker/dbms_rpc.go:130:28: func (*DBMSRPCService).Deploy is unused (U1000)
worker/dbms_rpc.go:156:28: func (*DBMSRPCService).SubscribeTransactions is unused (U1000)
worker/dbms_rpc.go:162:28: func (*DBMSRPCService).CancelSubscription is unused (U1000)
worker/errors.go:29:2: var ErrMultipleQuery is unused (U1000)
worker/errors.go:44:2: var ErrUnknownMuxRequest is unused (U1000)
worker/helper_test.go:93:25: func (*stubBPService).FetchLastIrreversibleBlock is unused (U1000)
worker/helper_test.go:106:25: func (*stubBPService).FetchBlockByCount is unused (U1000)
xenomint/chain.go:34:2: const inCommandBufferLength is unused (U1000)
xenomint/chain.go:35:2: const outCommandBufferLength is unused (U1000)
xenomint/chain.go:38:6: type applyRequest is unused (U1000)
xenomint/chain.go:43:6: type blockNode is unused (U1000)
xenomint/errors.go:29:2: var ErrQueryExists is unused (U1000)
xenomint/errors.go:31:2: var ErrStateClosed is unused (U1000)
xenomint/errors.go:35:2: var ErrLocalBehindRemote is unused (U1000)
xenomint/mux.go:89:22: func (*MuxService).Query is unused (U1000)
xenomint/mux.go:132:6: type MuxLeaderCommitRequest is unused (U1000)
xenomint/mux.go:140:6: type MuxLeaderCommitResponse is unused (U1000)
xenomint/pool.go:108:16: func (*pool).matchLast is unused (U1000)
xenomint/xxx_test.go:57:2: var testingTraceFile is unused (U1000)
xenomint/xxx_test.go:159:6: type randKeygen is unused (U1000)
xenomint/xxx_test.go:164:6: func newRandKeygen is unused (U1000)

@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #174 into develop will increase coverage by 1.23%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #174      +/-   ##
===========================================
+ Coverage    75.72%   76.96%   +1.23%     
===========================================
  Files          135      135              
  Lines        10946    10766     -180     
===========================================
- Hits          8289     8286       -3     
+ Misses        2011     1834     -177     
  Partials       646      646

@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #174 into develop will increase coverage by 1.15%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #174      +/-   ##
===========================================
+ Coverage     75.8%   76.96%   +1.15%     
===========================================
  Files          135      135              
  Lines        10950    10766     -184     
===========================================
- Hits          8301     8286      -15     
+ Misses        2004     1834     -170     
- Partials       645      646       +1

Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auxten auxten merged commit ed49168 into develop Jan 2, 2019
@laodouya laodouya deleted the feature/prune branch February 28, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants