Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless hash in base58 encoded private key #175

Merged
merged 4 commits into from Jan 2, 2019

Conversation

Projects
None yet
3 participants
@auxten
Copy link
Contributor

auxten commented Jan 2, 2019

  1. Use new salt for base58 private key
  2. Remove useless hash in base58 encoded private key
  3. Remove Build func and its test

@auxten auxten requested review from xq262144 and ggicci Jan 2, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #175 into develop will increase coverage by 0.07%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           develop    #175      +/-   ##
==========================================
+ Coverage    75.72%   75.8%   +0.07%     
==========================================
  Files          135     135              
  Lines        10947   10950       +3     
==========================================
+ Hits          8290    8301      +11     
+ Misses        2008    2004       -4     
+ Partials       649     645       -4
1 similar comment
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #175 into develop will increase coverage by 0.07%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           develop    #175      +/-   ##
==========================================
+ Coverage    75.72%   75.8%   +0.07%     
==========================================
  Files          135     135              
  Lines        10947   10950       +3     
==========================================
+ Hits          8290    8301      +11     
+ Misses        2008    2004       -4     
+ Partials       649     645       -4
@xq262144
Copy link
Contributor

xq262144 left a comment

Approve

@ggicci

ggicci approved these changes Jan 2, 2019

@ggicci ggicci merged commit db03770 into develop Jan 2, 2019

4 checks passed

ci/gitlab/gitlab.com Pipeline passed on GitLab
Details
codecov/project 75.8% (+0.07%) compared to fc03889
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@xq262144 xq262144 deleted the feature/privateKeyBase58 branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.