Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless hash in base58 encoded private key #175

Merged
merged 4 commits into from
Jan 2, 2019
Merged

Remove useless hash in base58 encoded private key #175

merged 4 commits into from
Jan 2, 2019

Conversation

auxten
Copy link
Contributor

@auxten auxten commented Jan 2, 2019

  1. Use new salt for base58 private key
  2. Remove useless hash in base58 encoded private key
  3. Remove Build func and its test

@auxten auxten requested review from xq262144 and ggicci January 2, 2019 08:17
@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #175 into develop will increase coverage by 0.07%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           develop    #175      +/-   ##
==========================================
+ Coverage    75.72%   75.8%   +0.07%     
==========================================
  Files          135     135              
  Lines        10947   10950       +3     
==========================================
+ Hits          8290    8301      +11     
+ Misses        2008    2004       -4     
+ Partials       649     645       -4

1 similar comment
@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #175 into develop will increase coverage by 0.07%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           develop    #175      +/-   ##
==========================================
+ Coverage    75.72%   75.8%   +0.07%     
==========================================
  Files          135     135              
  Lines        10947   10950       +3     
==========================================
+ Hits          8290    8301      +11     
+ Misses        2008    2004       -4     
+ Partials       649     645       -4

xq262144
xq262144 approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@ggicci ggicci merged commit db03770 into develop Jan 2, 2019
@xq262144 xq262144 deleted the feature/privateKeyBase58 branch January 2, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xq262144 xq262144 xq262144 approved these changes

@ggicci ggicci ggicci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@auxten @xq262144 @ggicci