Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade transaction structure: add Timestamp field #177

Merged
merged 7 commits into from
Jan 4, 2019

Conversation

ggicci
Copy link
Contributor

@ggicci ggicci commented Jan 2, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #177 into develop will increase coverage by 0.11%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop    #177      +/-   ##
==========================================
+ Coverage    76.98%   77.1%   +0.11%     
==========================================
  Files          135     135              
  Lines        10770   10773       +3     
==========================================
+ Hits          8291    8306      +15     
+ Misses        1835    1824      -11     
+ Partials       644     643       -1

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #177 into develop will decrease coverage by 0.08%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #177      +/-   ##
===========================================
- Coverage    77.09%   77.01%   -0.09%     
===========================================
  Files          135      135              
  Lines        10848    10853       +5     
===========================================
- Hits          8363     8358       -5     
- Misses        1842     1848       +6     
- Partials       643      647       +4

@auxten
Copy link
Contributor

auxten commented Jan 3, 2019

Fix PR name according to our coding guide

@ggicci ggicci changed the title Feature/transaction timestamp Upgrade transaction structure: add Timestamp field Jan 3, 2019
Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@xq262144 xq262144 merged commit 7d7887a into develop Jan 4, 2019
@xq262144 xq262144 deleted the feature/transactionTimestamp branch January 4, 2019 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants