Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove base58 wallet address #179

Merged
merged 6 commits into from
Jan 3, 2019
Merged

Remove base58 wallet address #179

merged 6 commits into from
Jan 3, 2019

Conversation

auxten
Copy link
Contributor

@auxten auxten commented Jan 2, 2019

No description provided.

Copy link
Contributor

@zeqing-guo zeqing-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #179 into develop will decrease coverage by 1.28%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #179      +/-   ##
===========================================
- Coverage    77.13%   75.84%   -1.29%     
===========================================
  Files          135      135              
  Lines        10770    10933     +163     
===========================================
- Hits          8307     8292      -15     
- Misses        1821     2001     +180     
+ Partials       642      640       -2

@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #179 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop    #179      +/-   ##
==========================================
- Coverage    77.14%   77.1%   -0.04%     
==========================================
  Files          135     135              
  Lines        10771   10754      -17     
==========================================
- Hits          8309    8292      -17     
- Misses        1820    1822       +2     
+ Partials       642     640       -2

@auxten auxten requested a review from laodouya January 3, 2019 04:02
cmd/cql-faucet/api.go Outdated Show resolved Hide resolved
Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@xq262144 xq262144 merged commit aa4cee5 into develop Jan 3, 2019
@auxten auxten deleted the feature/utilsOptimize branch January 3, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants