Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify cql and cql-utils log #184

Merged
merged 7 commits into from
Jan 3, 2019
Merged

Simplify cql and cql-utils log #184

merged 7 commits into from
Jan 3, 2019

Conversation

auxten
Copy link
Contributor

@auxten auxten commented Jan 3, 2019

  • Rename conf.GConf.BillingPeriod to conf.GConf.BillingBlockCount
  • Disable CallerHook if utils.log.SimpleLog == "Y"
  • Add ldflags_role_client_simple_log in makefile
  • Update conf BillingPeriod to BillingBlockCount

@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #184 into develop will increase coverage by 0.07%.
The diff coverage is 71.42%.

@@             Coverage Diff             @@
##           develop     #184      +/-   ##
===========================================
+ Coverage    77.03%   77.11%   +0.07%     
===========================================
  Files          135      135              
  Lines        10799    10775      -24     
===========================================
- Hits          8319     8309      -10     
+ Misses        1836     1817      -19     
- Partials       644      649       +5

@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #184 into develop will increase coverage by 0.11%.
The diff coverage is 71.42%.

@@             Coverage Diff             @@
##           develop     #184      +/-   ##
===========================================
+ Coverage    77.03%   77.14%   +0.11%     
===========================================
  Files          135      135              
  Lines        10799    10803       +4     
===========================================
+ Hits          8319     8334      +15     
+ Misses        1836     1822      -14     
- Partials       644      647       +3

Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@leventeliu leventeliu merged commit 504cb94 into develop Jan 3, 2019
@leventeliu leventeliu deleted the feature/cqlLogOpt branch January 3, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants