Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for database creation fix #185

Merged
merged 4 commits into from Jan 4, 2019

Conversation

Projects
None yet
3 participants
@xq262144
Copy link
Contributor

xq262144 commented Jan 3, 2019

No description provided.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #185 into develop will decrease coverage by 0.05%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop     #185      +/-   ##
===========================================
- Coverage    77.03%   76.97%   -0.06%     
===========================================
  Files          135      135              
  Lines        10799    10754      -45     
===========================================
- Hits          8319     8278      -41     
+ Misses        1836     1830       -6     
- Partials       644      646       +2
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #185 into develop will increase coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop     #185      +/-   ##
===========================================
+ Coverage    77.01%   77.02%   +<.01%     
===========================================
  Files          135      135              
  Lines        10853    10853              
===========================================
+ Hits          8358     8359       +1     
+ Misses        1851     1848       -3     
- Partials       644      646       +2

@xq262144 xq262144 force-pushed the bugfix/waitForDatabaseCreation branch from 8840e60 to 0152bae Jan 4, 2019

@xq262144 xq262144 changed the title Wait for database creation fix and confgen prompt fix Wait for database creation fix Jan 4, 2019

@zeqing-guo
Copy link
Contributor

zeqing-guo left a comment

Approve

@ggicci

ggicci approved these changes Jan 4, 2019

@ggicci ggicci merged commit e158ed9 into develop Jan 4, 2019

4 checks passed

ci/gitlab/gitlab.com Pipeline passed on GitLab
Details
codecov/project 77.02% (+<.01%) compared to 7d7887a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@xq262144 xq262144 deleted the bugfix/waitForDatabaseCreation branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.