Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coping with sqlchain soft forks #201

Merged
merged 5 commits into from
Jan 14, 2019
Merged

Coping with sqlchain soft forks #201

merged 5 commits into from
Jan 14, 2019

Conversation

xq262144
Copy link
Contributor

@xq262144 xq262144 commented Jan 8, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #201 into develop will decrease coverage by 0.16%.
The diff coverage is 71.42%.

@@             Coverage Diff             @@
##           develop     #201      +/-   ##
===========================================
- Coverage    76.44%   76.28%   -0.17%     
===========================================
  Files          134      134              
  Lines        11074    11100      +26     
===========================================
+ Hits          8466     8468       +2     
- Misses        1964     1983      +19     
- Partials       644      649       +5

@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #201 into develop will increase coverage by 0.01%.
The diff coverage is 65.9%.

@@             Coverage Diff             @@
##           develop     #201      +/-   ##
===========================================
+ Coverage    76.14%   76.16%   +0.01%     
===========================================
  Files          136      136              
  Lines        11187    11213      +26     
===========================================
+ Hits          8518     8540      +22     
- Misses        2008     2012       +4     
  Partials       661      661

@xq262144 xq262144 changed the title [WIP] Coping with sqlchain soft forks Coping with sqlchain soft forks Jan 10, 2019
Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auxten auxten merged commit a1b81f4 into develop Jan 14, 2019
@auxten auxten deleted the bugfix/sideChainSoftForks branch January 14, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants