-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix block producers forking on startup #211
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #211 +/- ##
===========================================
- Coverage 76.27% 76.15% -0.13%
===========================================
Files 136 136
Lines 11179 11188 +9
===========================================
- Hits 8527 8520 -7
- Misses 1991 2005 +14
- Partials 661 663 +2 |
Codecov Report
@@ Coverage Diff @@
## develop #211 +/- ##
===========================================
- Coverage 76.27% 76.22% -0.06%
===========================================
Files 136 136
Lines 11179 11188 +9
===========================================
+ Hits 8527 8528 +1
- Misses 1991 2000 +9
+ Partials 661 660 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes
Notes
Configuring a
conf.BPStartupRequiredReachableCount
which is greater than 1 will require the genesis time to be in the future for a genesis startup, otherwise, no BP will be able to move forward.And it also requires at least
conf.BPStartupRequiredReachableCount
-1 BP(s) to be alive at any time, or the BP network will stop working forever.