Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block producers forking on startup #211

Merged
merged 5 commits into from
Jan 14, 2019
Merged

Fix block producers forking on startup #211

merged 5 commits into from
Jan 14, 2019

Conversation

leventeliu
Copy link
Contributor

Fixes

  1. Move limits package to conf.
  2. Fix a height overflow issue while calculating with time before genesis time.
  3. Add a parameter to configure required reachable BPs for genesis startup.

Notes

Configuring a conf.BPStartupRequiredReachableCount which is greater than 1 will require the genesis time to be in the future for a genesis startup, otherwise, no BP will be able to move forward.
And it also requires at least conf.BPStartupRequiredReachableCount-1 BP(s) to be alive at any time, or the BP network will stop working forever.

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #211 into develop will decrease coverage by 0.12%.
The diff coverage is 80.55%.

@@             Coverage Diff             @@
##           develop     #211      +/-   ##
===========================================
- Coverage    76.27%   76.15%   -0.13%     
===========================================
  Files          136      136              
  Lines        11179    11188       +9     
===========================================
- Hits          8527     8520       -7     
- Misses        1991     2005      +14     
- Partials       661      663       +2

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #211 into develop will decrease coverage by 0.05%.
The diff coverage is 81.08%.

@@             Coverage Diff             @@
##           develop     #211      +/-   ##
===========================================
- Coverage    76.27%   76.22%   -0.06%     
===========================================
  Files          136      136              
  Lines        11179    11188       +9     
===========================================
+ Hits          8527     8528       +1     
- Misses        1991     2000       +9     
+ Partials       661      660       -1

Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leventeliu leventeliu merged commit cf292b4 into develop Jan 14, 2019
@leventeliu leventeliu deleted the feature/startup branch January 14, 2019 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants