Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gitlab ci script pipline will not return failed when go test failed. #216

Merged
merged 2 commits into from
Jan 15, 2019

Conversation

laodouya
Copy link
Member

Run like this:

#!/bin/bash
set -e
true && false && true
echo "Should not shown"

@codecov
Copy link

codecov bot commented Jan 14, 2019

Codecov Report

Merging #216 into develop will increase coverage by 9.36%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #216      +/-   ##
===========================================
+ Coverage    66.82%   76.18%   +9.36%     
===========================================
  Files          164      136      -28     
  Lines        13763    11213    -2550     
===========================================
- Hits          9197     8543     -654     
+ Misses        3462     2010    -1452     
+ Partials      1104      660     -444

Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@zeqing-guo zeqing-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@zeqing-guo zeqing-guo merged commit 5738430 into develop Jan 15, 2019
@zeqing-guo zeqing-guo deleted the bugfix/gitlabci_script branch January 15, 2019 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants