Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block producer genesis block hash mismatch #217

Merged
merged 6 commits into from
Jan 17, 2019
Merged

Fix block producer genesis block hash mismatch #217

merged 6 commits into from
Jan 17, 2019

Conversation

leventeliu
Copy link
Contributor

  • Use standard verifier.DefaultHashSignVerifierImpl in BPBlock instead of the old implementation.
  • Split Sign and Verify methods of verifier interface into SetHash, SignHash, VerifyHash, and VerifySignature.
  • Use SetHash to rewrite genesis block hash on cqld bootstrap, and use VerifyHash to verify it in the main chain.

@CovenantSQL CovenantSQL deleted a comment from codecov bot Jan 15, 2019
@CovenantSQL CovenantSQL deleted a comment from codecov bot Jan 15, 2019
@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #217 into beta will increase coverage by 0.13%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             beta     #217      +/-   ##
==========================================
+ Coverage   76.27%   76.41%   +0.13%     
==========================================
  Files         136      136              
  Lines       11230    11247      +17     
==========================================
+ Hits         8566     8594      +28     
+ Misses       2005     1999       -6     
+ Partials      659      654       -5

@leventeliu leventeliu changed the base branch from develop to beta January 15, 2019 13:04
@leventeliu leventeliu changed the title [WIP] Fix block producer genesis block hash mismatch Fix block producer genesis block hash mismatch Jan 17, 2019
Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auxten auxten merged commit 6026fab into beta Jan 17, 2019
@leventeliu leventeliu deleted the bugfix/startup branch January 17, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants