Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add other cmd tools in observer image #222

Merged
merged 2 commits into from
Jan 21, 2019
Merged

Add other cmd tools in observer image #222

merged 2 commits into from
Jan 21, 2019

Conversation

zeqing-guo
Copy link
Contributor

@zeqing-guo zeqing-guo commented Jan 18, 2019 •
edited
Loading

OB needs to pay advance payment for reading blocks

@codecov
Copy link

codecov bot commented Jan 18, 2019 •
edited
Loading

Codecov Report

Merging #222 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #222      +/-   ##
===========================================
- Coverage    76.36%   76.35%   -0.01%     
===========================================
  Files          136      136              
  Lines        11230    11230              
===========================================
- Hits          8576     8575       -1     
+ Misses        1994     1993       -1     
- Partials       660      662       +2

@zeqing-guo zeqing-guo changed the title Add other cmd tool in observer image Add other cmd tools in observer image Jan 20, 2019
laodouya
laodouya approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@laodouya laodouya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

leventeliu
leventeliu approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@leventeliu leventeliu merged commit b9e6d72 into develop Jan 21, 2019
@leventeliu leventeliu deleted the feature/observer_docker branch January 21, 2019 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laodouya laodouya laodouya approved these changes

@leventeliu leventeliu leventeliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zeqing-guo @laodouya @leventeliu