-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metric web for cqld and cql-minerd #227
Conversation
5bec8f5
to
7b8db5f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #227 +/- ##
===========================================
+ Coverage 76.03% 76.08% +0.04%
===========================================
Files 136 139 +3
Lines 11281 11494 +213
===========================================
+ Hits 8578 8745 +167
- Misses 2046 2080 +34
- Partials 657 669 +12 |
Codecov Report
@@ Coverage Diff @@
## develop #227 +/- ##
===========================================
- Coverage 75.95% 75.91% -0.05%
===========================================
Files 136 139 +3
Lines 11287 11500 +213
===========================================
+ Hits 8573 8730 +157
- Misses 2053 2096 +43
- Partials 661 674 +13 |
EB int64 = TB * 1024 | ||
// ZB is 1024 EB | ||
ZB int64 = TB * 1024 | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be refactored as:
// Defines byte units.
const (
_ = iota
KB int64 = 1 << (10 * iota)
MB
GB
TB
...
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
flag.Usage = func() { | ||
fmt.Fprintf(os.Stderr, "\n%s\n\n", desc) | ||
fmt.Fprintf(os.Stderr, "Usage: %s [arguments]\n", name) | ||
_, _ = fmt.Fprintf(os.Stderr, "\n%s\n\n", desc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore return vars explicitly is recommend
…QL into feature/httpMetric
/debug/metrics
for chart and num/debug/vars
for json