Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ~/.cql/ directory as default config location. #233

Merged
merged 28 commits into from
Jan 28, 2019
Merged

Conversation

laodouya
Copy link
Member

@laodouya laodouya commented Jan 24, 2019

  1. Change all cmd config param to ~/.cql/config.yaml
  2. Config generate will default use ~/.cql/ as well.
  3. Driver can reduce client.Init func call if expected using ~/.cql/
  4. Update all unit test.
  5. Update all README.md
  6. Update client example.
  7. Compatible with elder usage.
  8. Skip compatibility test if branch name contains '/beta_'

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #233 into develop will decrease coverage by 0.27%.
The diff coverage is 40%.

@@             Coverage Diff             @@
##           develop     #233      +/-   ##
===========================================
- Coverage    77.85%   77.57%   -0.28%     
===========================================
  Files          150      150              
  Lines        11914    11931      +17     
===========================================
- Hits          9276     9256      -20     
- Misses        1946     1977      +31     
- Partials       692      698       +6

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #233 into develop will decrease coverage by 0.25%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           develop    #233      +/-   ##
==========================================
- Coverage    77.85%   77.6%   -0.26%     
==========================================
  Files          150     150              
  Lines        11914   11931      +17     
==========================================
- Hits          9276    9259      -17     
- Misses        1946    1974      +28     
- Partials       692     698       +6

Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xq262144 xq262144 merged commit c13a14c into develop Jan 28, 2019
@laodouya laodouya deleted the feature/dsn branch January 28, 2019 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants