Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing private key and rename apinode to fullnode #236

Merged
merged 6 commits into from
Jan 29, 2019

Conversation

ggicci
Copy link
Contributor

@ggicci ggicci commented Jan 28, 2019

No description provided.

@ggicci ggicci requested a review from laodouya January 28, 2019 11:07
@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #236 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #236      +/-   ##
===========================================
+ Coverage    77.73%   77.75%   +0.02%     
===========================================
  Files          150      150              
  Lines        11932    11931       -1     
===========================================
+ Hits          9275     9277       +2     
+ Misses        1962     1960       -2     
+ Partials       695      694       -1

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #236 into develop will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop    #236      +/-   ##
==========================================
+ Coverage    77.63%   77.7%   +0.06%     
==========================================
  Files          150     150              
  Lines        11934   11934              
==========================================
+ Hits          9265    9273       +8     
+ Misses        1973    1966       -7     
+ Partials       696     695       -1

Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@laodouya laodouya merged commit bbe8631 into develop Jan 29, 2019
@laodouya laodouya deleted the hotfix/fullnode_docker branch January 29, 2019 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants