Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve database query performance #240

Merged
merged 42 commits into from
Jan 30, 2019
Merged

Improve database query performance #240

merged 42 commits into from
Jan 30, 2019

Conversation

xq262144
Copy link
Contributor

  1. Add trace regions and trace wrapper.
  2. Defer response signing process.
  3. Log fetch logic for follower live recover.

leventeliu and others added 30 commits January 29, 2019 16:36
@leventeliu
Fix log field name typo
cae71f2
@leventeliu
Fix comment typo
40ca3c3
@leventeliu
Complete kayak trace logs
0105c4f
Add backward compatible trace lib
133add2
Add timer feature for performance analysis
656cece
Add comment to runtime/trace wrapper
ecd7e7d
Add trace to kayak
db099cf
Add more trace points
a5b3d5f
Fix rpc trace point and split followerApply task types
3c5d3b5
Calc follower real commitcycle cost
287a5b7
Separate commit wait and commit cycle cost
eb50216
Fix waitForLastCommit region overlapping
7e4a0c0
Fix rollback nil pointer bug
6d4f87b
Fix shutdown block bug
59dc00b
Fix chain produce block bug
951e879
Fix chainbus service code typo
5752a42
Increase provide service interval and send provide service request af…
57ae1fe 
…ter database creation
Add kayak fetch log recover and make zero commitThreshold configurable
5014de4
Adjust log wait timeout
649947e
Use direct function call instead of rpc call in kayak test
0a4f691
Add rpc parallel request test
78f406c
Fix shared secret cache bug
4bd20e8
Use back the fake pipe rpc feature
ba2231c
Add more metric tests and fix race and test case bug
2450952
Disable manual trace in runtime test
80c8f38
Even more traces
fb4d453
Use client pool and connection pool for multiple physical connections
af4da18
Drop off nested signature in embedded request/response/ack structure
20f4f85
Remove response signature check
26546d2
Remove useless traces
cb3a864
@xq262144 xq262144 changed the title Improve kayak performance Improve database query performance Jan 29, 2019
covenantdb
covenantdb reviewed Jan 29, 2019
View reviewed changes
rpc/clientpool_caller.go Outdated Show resolved Hide resolved
rpc/clientpool_caller.go Outdated Show resolved Hide resolved
rpc/pool.go Outdated Show resolved Hide resolved
@CovenantSQL CovenantSQL deleted a comment from codecov bot Jan 29, 2019
@CovenantSQL CovenantSQL deleted a comment from codecov bot Jan 30, 2019
@CovenantSQL CovenantSQL deleted a comment from codecov bot Jan 30, 2019
@codecov
Copy link

codecov bot commented Jan 30, 2019 •
edited

Codecov Report

Merging #240 into beta will decrease coverage by 2.07%.
The diff coverage is 65.8%.

@@            Coverage Diff             @@
##             beta     #240      +/-   ##
==========================================
- Coverage   77.84%   75.76%   -2.08%     
==========================================
  Files         150      159       +9     
  Lines       12014    12198     +184     
==========================================
- Hits         9352     9242     -110     
- Misses       1975     2264     +289     
- Partials      687      692       +5

@CovenantSQL CovenantSQL deleted a comment from codecov bot Jan 30, 2019
ggicci
ggicci reviewed Jan 30, 2019
View reviewed changes
alltest.sh Show resolved Hide resolved
auxten
auxten approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ship it!

zeqing-guo
zeqing-guo approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@zeqing-guo zeqing-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@auxten auxten merged commit 0e5f056 into beta Jan 30, 2019
@laodouya laodouya deleted the feature/beta_trace branch February 28, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@covenantdb covenantdb covenantdb left review comments

@auxten auxten auxten approved these changes

@ggicci ggicci ggicci approved these changes

@zeqing-guo zeqing-guo zeqing-guo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xq262144 @auxten @ggicci @zeqing-guo @covenantdb @leventeliu