Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit test cover ratio. #251

Merged
merged 18 commits into from
Feb 18, 2019
Merged

Improve unit test cover ratio. #251

merged 18 commits into from
Feb 18, 2019

Conversation

laodouya
Copy link
Member

  1. Improve unit test cover ratio.
  2. Fix minor bug
  3. Unit duplicate funcs
  4. Add test package for test support funcs and ingore test package cover ratio.

@laodouya
Add unit test for client package.
1a2779b
@laodouya
Update unit test bp config2.
d4f2225
@laodouya
Start local test server while testing defaultInit.
bb9693d
@laodouya
Add test case for functions that added in last commit.
d54da5e
@laodouya
Move worker common support test func to helper_test.go file
dbe8462
@laodouya
Combine two dupConf func into test.DupConf
f398f32
@laodouya
Replace node_standalone/config2.yaml to test.DupConf
ce3f5da
@laodouya
Add client.TransferToken test.
a0da709
@laodouya
Add client.UpdatePermission test.
d7eb5c1
@laodouya
Add runPeerListUpdater goroutine test.
4caa19a
@laodouya
Unit test cover rpc.ResetClient func.
1d82718
@laodouya
Fix one missing return bug. Incrase blockproducer unit test cover ratio
1931f20
@laodouya
Incrase blockproducer/metastate unit test cover ratio
31e7ca3
@laodouya
Move test support bp func to test package.
5c0fe24
@laodouya
Move DupConf to utils package.
b9f74b5
@laodouya
Rename bp.WaitDatabaseCreation to client.WaitBPDatabaseCreation.
6168bff
@laodouya
Imporve unit test cover for supportive code
efc8ecc
@laodouya
Imporve unit test cover for supportive code
6611843
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #251 into develop will increase coverage by 2.79%.
The diff coverage is 96.92%.

@@             Coverage Diff             @@
##           develop     #251      +/-   ##
===========================================
+ Coverage    75.88%   78.67%   +2.79%     
===========================================
  Files          159      160       +1     
  Lines        12198    12136      -62     
===========================================
+ Hits          9256     9548     +292     
+ Misses        2241     1906     -335     
+ Partials       701      682      -19

1 similar comment
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #251 into develop will increase coverage by 2.79%.
The diff coverage is 96.92%.

@@             Coverage Diff             @@
##           develop     #251      +/-   ##
===========================================
+ Coverage    75.88%   78.67%   +2.79%     
===========================================
  Files          159      160       +1     
  Lines        12198    12136      -62     
===========================================
+ Hits          9256     9548     +292     
+ Misses        2241     1906     -335     
+ Partials       701      682      -19

auxten
auxten approved these changes Feb 16, 2019
View reviewed changes
Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

xq262144
xq262144 approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@xq262144 xq262144 merged commit 6efc92a into develop Feb 18, 2019
@laodouya laodouya deleted the feature/unittest branch February 18, 2019 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auxten auxten auxten approved these changes

@xq262144 xq262144 xq262144 approved these changes

@leventeliu leventeliu Awaiting requested review from leventeliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@laodouya @auxten @xq262144