Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor observer synchronization to pull mode #256

Merged
merged 3 commits into from
Feb 18, 2019

Conversation

xq262144
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #256 into develop will increase coverage by 0.02%.
The diff coverage is 69.76%.

@@             Coverage Diff             @@
##           develop     #256      +/-   ##
===========================================
+ Coverage    79.16%   79.18%   +0.02%     
===========================================
  Files          160      160              
  Lines        12136    11954     -182     
===========================================
- Hits          9607     9466     -141     
+ Misses        1844     1813      -31     
+ Partials       685      675      -10

1 similar comment
@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #256 into develop will increase coverage by 0.02%.
The diff coverage is 69.76%.

@@             Coverage Diff             @@
##           develop     #256      +/-   ##
===========================================
+ Coverage    79.16%   79.18%   +0.02%     
===========================================
  Files          160      160              
  Lines        12136    11954     -182     
===========================================
- Hits          9607     9466     -141     
+ Misses        1844     1813      -31     
+ Partials       685      675      -10

Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auxten auxten merged commit ca7c7ce into develop Feb 18, 2019
@laodouya laodouya deleted the feature/pull_mode_observer branch February 18, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants