Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit test cover ratio #257

Merged
merged 11 commits into from
Feb 20, 2019
Merged

Improve unit test cover ratio #257

merged 11 commits into from
Feb 20, 2019

Conversation

laodouya
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #257 into develop will increase coverage by 0.17%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #257      +/-   ##
===========================================
+ Coverage     79.2%   79.37%   +0.17%     
===========================================
  Files          160      160              
  Lines        11954    11954              
===========================================
+ Hits          9468     9489      +21     
+ Misses        1808     1786      -22     
- Partials       678      679       +1

@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #257 into develop will increase coverage by 1.59%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #257      +/-   ##
===========================================
+ Coverage    79.24%   80.84%   +1.59%     
===========================================
  Files          160      159       -1     
  Lines        11954    11876      -78     
===========================================
+ Hits          9473     9601     +128     
+ Misses        1804     1586     -218     
- Partials       677      689      +12

Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auxten auxten merged commit 5063377 into develop Feb 20, 2019
@laodouya laodouya deleted the feature/unittest branch February 21, 2019 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants