Combine createRandomBlock functions into one. #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
laodouya
commented
Feb 18, 2019
•
laodouya
commented
- Rename createRandomBlock functions to types.CreateRandomBlock
- Replace all createRandomBlock to reuse types.CreateRandomBlock
- Refactor createRandomBlock() in sqlchain/xxx_test.go to reuse types.CreateRandomBlock
laodouya
changed the title
Codecov Report
@@ Coverage Diff @@
## beta #258 +/- ##
==========================================
- Coverage 78.97% 78.85% -0.13%
==========================================
Files 159 159
Lines 11955 11981 +26
==========================================
+ Hits 9442 9448 +6
- Misses 1828 1846 +18
- Partials 685 687 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.