Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kayak memleak bugs #277

Merged
merged 29 commits into from
May 9, 2019
Merged

Fix kayak memleak bugs #277

merged 29 commits into from
May 9, 2019

Conversation

xq262144
Copy link
Contributor

@xq262144 xq262144 commented Mar 7, 2019

No description provided.

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #277 into develop will increase coverage by 0.33%.
The diff coverage is 67.83%.

@@             Coverage Diff             @@
##           develop     #277      +/-   ##
===========================================
+ Coverage    80.76%   81.09%   +0.33%     
===========================================
  Files          174      173       -1     
  Lines        12209    12234      +25     
===========================================
+ Hits          9860     9921      +61     
+ Misses        1610     1569      -41     
- Partials       739      744       +5

@CovenantSQL CovenantSQL deleted a comment from codecov bot Mar 7, 2019
@xq262144 xq262144 force-pushed the bugfix/kayak_memleak branch 2 times, most recently from 724573e to 356ca3b Compare March 28, 2019 02:23
@xq262144 xq262144 changed the title Fix kayak memleak bugs [WIP] Fix kayak memleak bugs Mar 28, 2019
@xq262144 xq262144 force-pushed the bugfix/kayak_memleak branch 2 times, most recently from 5e41624 to d4c96eb Compare March 29, 2019 01:01
@laodouya laodouya force-pushed the bugfix/kayak_memleak branch 8 times, most recently from 8f92b06 to e653567 Compare April 10, 2019 03:26
@laodouya laodouya changed the title [WIP] Fix kayak memleak bugs Fix kayak memleak bugs Apr 28, 2019
@laodouya laodouya changed the title Fix kayak memleak bugs [WIP] Fix kayak memleak bugs Apr 28, 2019
@laodouya laodouya changed the title [WIP] Fix kayak memleak bugs Fix kayak memleak bugs May 9, 2019
@laodouya laodouya requested review from auxten and leventeliu May 9, 2019 10:17
Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approve.

@leventeliu leventeliu merged commit 3af7b8d into develop May 9, 2019
@leventeliu leventeliu deleted the bugfix/kayak_memleak branch May 9, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants