Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor faucet for new testnet logic #286

Merged
merged 14 commits into from
Mar 21, 2019
Merged

Refactor faucet for new testnet logic #286

merged 14 commits into from
Mar 21, 2019

Conversation

xq262144
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #286 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop    #286      +/-   ##
==========================================
- Coverage    80.52%   80.5%   -0.02%     
==========================================
  Files          160     160              
  Lines        11949   11944       -5     
==========================================
- Hits          9622    9616       -6     
- Misses        1632    1633       +1     
  Partials       695     695

Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xq262144 xq262144 merged commit efcafe8 into develop Mar 21, 2019
@leventeliu leventeliu deleted the feature/faucet_v2 branch May 15, 2019 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants