Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support read-only local mirror #288

Merged
merged 22 commits into from
Mar 22, 2019
Merged

Support read-only local mirror #288

merged 22 commits into from
Mar 22, 2019

Conversation

xq262144
Copy link
Contributor

  1. support mirroring database to local using cql mirror command.
  2. support accessing mirrored database using cql command.
  3. support accessing mirrored database using http adapter.

@codecov
Copy link

codecov bot commented Mar 22, 2019 •
edited
Loading

Codecov Report

Merging #288 into develop will decrease coverage by 0.14%.
The diff coverage is 69.7%.

@@             Coverage Diff             @@
##           develop     #288      +/-   ##
===========================================
- Coverage    80.36%   80.21%   -0.15%     
===========================================
  Files          161      164       +3     
  Lines        11957    12166     +209     
===========================================
+ Hits          9609     9759     +150     
- Misses        1645     1682      +37     
- Partials       703      725      +22

@CovenantSQL CovenantSQL deleted a comment from codecov bot Mar 22, 2019
auxten
auxten reviewed Mar 22, 2019
View reviewed changes
sqlchain/mirror/server.go Outdated Show resolved Hide resolved
leventeliu
leventeliu approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@leventeliu leventeliu merged commit 359a508 into develop Mar 22, 2019
@leventeliu leventeliu deleted the feature/client_readonly_cache branch March 22, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auxten auxten auxten left review comments

@laodouya laodouya laodouya approved these changes

@leventeliu leventeliu leventeliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xq262144 @auxten @laodouya @leventeliu