Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all cql-utils functions to cql command #291

Merged
merged 25 commits into from
Mar 27, 2019
Merged

Conversation

laodouya
Copy link
Member

cql command now add three subcommands:
rpc
generate
idminer

@laodouya laodouya requested review from xq262144, leventeliu and auxten and removed request for leventeliu March 26, 2019 11:47
@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #291 into develop will decrease coverage by 0.09%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop     #291     +/-   ##
==========================================
- Coverage    80.72%   80.62%   -0.1%     
==========================================
  Files          164      164             
  Lines        12030    12031      +1     
==========================================
- Hits          9711     9700     -11     
- Misses        1599     1605      +6     
- Partials       720      726      +6

@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #291 into develop will decrease coverage by 0.11%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop    #291      +/-   ##
==========================================
- Coverage    80.72%   80.6%   -0.12%     
==========================================
  Files          164     164              
  Lines        12030   12030              
==========================================
- Hits          9711    9697      -14     
- Misses        1599    1607       +8     
- Partials       720     726       +6

client/driver.go Outdated Show resolved Hide resolved
Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auxten auxten merged commit 18e650b into develop Mar 27, 2019
@laodouya laodouya deleted the feature/cql_utils_refactor branch March 27, 2019 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants