Refactor ETLS/RPC/mux packages #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
covenantdb
reviewed
Apr 1, 2019
covenantdb
reviewed
Apr 2, 2019
leventeliu
changed the title
covenantdb
reviewed
Apr 4, 2019
Codecov Report
@@ Coverage Diff @@
## develop #303 +/- ##
===========================================
- Coverage 81.06% 80.92% -0.15%
===========================================
Files 162 173 +11
Lines 11883 12056 +173
===========================================
+ Hits 9633 9756 +123
- Misses 1544 1581 +37
- Partials 706 719 +13 |
laodouya
reviewed
Apr 8, 2019
xq262144
approved these changes
Apr 8, 2019
laodouya
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesigned package hierarchies:
crypto/etls: provides crypto connection, doesn't know aboutNodeIDnoconn: based oncrypto/etls, node-oriented connection, depends on a node IDResolver; providesnoconnDial/DialEx/Accept methodsrpc: based onnoconn, definesServer/NodeConnPoolinterface/Caller/PersistentCallerrpc/mux: multiplexing version ofrpc; implements a common used version ofResolverinterface