Lower memory consumption while rebuilding chain #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #322 +/- ##
===========================================
- Coverage 81.07% 80.84% -0.24%
===========================================
Files 174 174
Lines 12119 12143 +24
===========================================
- Hits 9826 9817 -9
- Misses 1571 1594 +23
- Partials 722 732 +10 |
Codecov Report
@@ Coverage Diff @@
## develop #322 +/- ##
===========================================
- Coverage 81.07% 80.86% -0.22%
===========================================
Files 174 174
Lines 12119 12132 +13
===========================================
- Hits 9826 9810 -16
- Misses 1571 1592 +21
- Partials 722 730 +8 |
xq262144
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the former implementation, the chain reads every block from the storage to rebuild branches. This will cost higher and higher memory consumption with the increase of chain height.
Note that it uses the persistent immutable state, which is the state snapshot of the last irreversible block, as a base, and replays any successive block to rebuild the branch state. So actually only the blocks after the last irreversible block, aka the reversible blocks, are needed here. Hence here comes this fix.