Faucet api update & cql command improvement #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xq262144
commented
May 6, 2019
xq262144
commented
- Add new faucet api for remote key management.
- Improve CQL command with miner config generation and existing private key config generation support.
Codecov Report
@@ Coverage Diff @@
## develop #324 +/- ##
==========================================
- Coverage 81.44% 80.95% -0.5%
==========================================
Files 174 174
Lines 12134 12209 +75
==========================================
+ Hits 9883 9884 +1
- Misses 1518 1588 +70
- Partials 733 737 +4 |
Codecov Report
@@ Coverage Diff @@
## develop #324 +/- ##
===========================================
- Coverage 81.44% 80.68% -0.77%
===========================================
Files 174 174
Lines 12134 12209 +75
===========================================
- Hits 9883 9851 -32
- Misses 1518 1627 +109
+ Partials 733 731 -2 |
added 7 commits
May 6, 2019 17:16
laodouya
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.