Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cql misunderstanding #329

Merged
merged 12 commits into from
May 15, 2019
Merged

Fix cql misunderstanding #329

merged 12 commits into from
May 15, 2019

Conversation

laodouya
Copy link
Member

  1. refactor cql grant
  2. group command params and refactor help print
  3. fix transfer params misunderstanding

@laodouya laodouya changed the title fix cql misunderstanding Fix cql misunderstanding May 14, 2019
@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #329 into develop will increase coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #329      +/-   ##
===========================================
+ Coverage    80.53%   80.66%   +0.13%     
===========================================
  Files          173      173              
  Lines        12278    12278              
===========================================
+ Hits          9888     9904      +16     
+ Misses        1652     1636      -16     
  Partials       738      738

@codecov
Copy link

codecov bot commented May 14, 2019 •
edited
Loading

Codecov Report

Merging #329 into develop will decrease coverage by 0.39%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           develop    #329     +/-   ##
=========================================
- Coverage    80.89%   80.5%   -0.4%     
=========================================
  Files          173     173             
  Lines        12278   12278             
=========================================
- Hits          9932    9884     -48     
- Misses        1599    1657     +58     
+ Partials       747     737     -10

leventeliu
leventeliu approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

auxten
auxten approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auxten auxten merged commit 127d925 into develop May 15, 2019
@laodouya laodouya deleted the feature/fix_cql_misunderstanding branch May 15, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auxten auxten auxten approved these changes

@leventeliu leventeliu leventeliu approved these changes

@xq262144 xq262144 Awaiting requested review from xq262144

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@laodouya @auxten @leventeliu