-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix provide service miner overcharge deposit bug #331
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #331 +/- ##
===========================================
+ Coverage 80.5% 80.52% +0.02%
===========================================
Files 173 173
Lines 12278 12284 +6
===========================================
+ Hits 9884 9892 +8
+ Misses 1657 1648 -9
- Partials 737 744 +7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -723,7 +723,7 @@ func (c *Chain) replaceAndSwitchToBranch( | |||
for _, b := range newIrres { | |||
txCount += b.txCount | |||
for _, tx := range b.load().Transactions { | |||
if err := c.immutable.apply(tx); err != nil { | |||
if err := c.immutable.apply(tx, newBranch.head.height); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe b.height
here?
No description provided.