Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generate choose testnet region ability #366

Merged
merged 4 commits into from
Aug 6, 2019
Merged

Add generate choose testnet region ability #366

merged 4 commits into from
Aug 6, 2019

Conversation

laodouya
Copy link
Member

@laodouya laodouya commented Aug 6, 2019

No description provided.

@auxten auxten changed the title Add generate choose testnet region ability. Add generate choose testnet region ability Aug 6, 2019
auxten
auxten approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ConnorLi96
ConnorLi96 approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@ConnorLi96 ConnorLi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD!

@laodouya laodouya merged commit 1996420 into develop Aug 6, 2019
@laodouya laodouya deleted the feature/sydney branch August 6, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@covenantdb covenantdb covenantdb left review comments

@auxten auxten auxten approved these changes

@ConnorLi96 ConnorLi96 ConnorLi96 approved these changes

@leventeliu leventeliu Awaiting requested review from leventeliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@laodouya @auxten @covenantdb @ConnorLi96