Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional database encryption support on database creation. #60

Merged
merged 18 commits into from Sep 13, 2018

Conversation

xq262144
Copy link
Contributor

@xq262144 xq262144 commented Sep 13, 2018

Add several bugfixes including:

  1. Optional database encryption support on database creation.
  2. SQLChain layer block production race condition bugfix.
  3. Client connection id allocation and error handling.
  4. Deadly simple runtime space resource limit checker.
  5. Merged new command line tool for SQL query & database creation/destroy.

Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

log.Fatalf("marshal response failed: %v", err)
os.Exit(-1)
return
} else {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)

Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@codecov
Copy link

codecov bot commented Sep 13, 2018

Codecov Report

Merging #60 into develop will increase coverage by 0.35%.
The diff coverage is 58%.

@@             Coverage Diff             @@
##           develop      #60      +/-   ##
===========================================
+ Coverage    76.24%   76.59%   +0.35%     
===========================================
  Files          126      126              
  Lines        10117    10192      +75     
===========================================
+ Hits          7714     7807      +93     
+ Misses        1516     1508       -8     
+ Partials       887      877      -10

log.Fatalf("marshal response failed: %v", err)
os.Exit(-1)
return
} else {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)

@leventeliu leventeliu merged commit 20c5551 into develop Sep 13, 2018
@auxten auxten changed the title Bugfix/storage Optional database encryption support on database creation. Sep 27, 2018
@leventeliu leventeliu deleted the bugfix/storage branch November 1, 2018 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants