New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional database encryption support on database creation. #60
Conversation
This reverts commit 1ab54cc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
cmd/idminer/main.go
Outdated
log.Fatalf("marshal response failed: %v", err) | ||
os.Exit(-1) | ||
return | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golint] reported by reviewdog 🐶
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Codecov Report
@@ Coverage Diff @@
## develop #60 +/- ##
===========================================
+ Coverage 76.24% 76.59% +0.35%
===========================================
Files 126 126
Lines 10117 10192 +75
===========================================
+ Hits 7714 7807 +93
+ Misses 1516 1508 -8
+ Partials 887 877 -10 |
cmd/idminer/main.go
Outdated
log.Fatalf("marshal response failed: %v", err) | ||
os.Exit(-1) | ||
return | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golint] reported by reviewdog 🐶
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
Add several bugfixes including: