Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion] Allow Comparators to read the amount of Fluid in a tank #364

Closed
wshadow opened this issue Oct 27, 2014 · 4 comments
Closed

[Suggestion] Allow Comparators to read the amount of Fluid in a tank #364

wshadow opened this issue Oct 27, 2014 · 4 comments
Labels
enhancement A feature request, an improvement, etc. good first issue An issue (usually a feature) looking for enthusiasts who can implement it. Also called help wanted.

Comments

@wshadow
Copy link
Contributor

wshadow commented Oct 27, 2014

I think it would be really useful, if you could read the amount of fluid that is in an iron tank. Using a comparator (similar how it works with vanilla chests) seems like an ideal solution.

I already created the pull request #360 that does this, but need some help/ideas on how to fix a bug with missing block updates (more detail on this in the pr). I guess I should have created this issue first... Oh well, if this turns out to be a bad idea and my code is not accepted, then I just have to live with it.
@Yopu Yopu added enhancement A feature request, an improvement, etc. good first issue An issue (usually a feature) looking for enthusiasts who can implement it. Also called help wanted. labels Oct 27, 2014
@wshadow
Copy link
Contributor Author

wshadow commented Feb 8, 2015

@Yopu thanks for your help on this issue. Only one small thing left. If you have a setup like in this screenshot the comparator doesn't update it's value unless it gets a blockupdate. With a vanilla chest this works just fine. So to be consistent with vanilla behavior we should also make setups like that work.

And yes, there is a valve behind the top cobblestone.

@Yopu
Copy link
Collaborator

Yopu commented Feb 8, 2015

Investigating.

@Yopu
Copy link
Collaborator

Yopu commented Feb 9, 2015

Fixed: dca915b

@Yopu Yopu closed this as completed Feb 9, 2015
@Yopu
Copy link
Collaborator

Yopu commented Feb 9, 2015

Thanks for the heads up @wshadow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A feature request, an improvement, etc. good first issue An issue (usually a feature) looking for enthusiasts who can implement it. Also called help wanted.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wshadow @Yopu