Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Python 2.7.16 #525

Closed
1fish2 opened this issue Apr 25, 2019 · 2 comments · Fixed by #528
Closed

Update to Python 2.7.16 #525

1fish2 opened this issue Apr 25, 2019 · 2 comments · Fixed by #528
Assignees
Labels
code refinement security security vulnerabilities

Comments

@1fish2
Copy link
Contributor

1fish2 commented Apr 25, 2019

With Python 2 support lasting until the end of 2019, they released update 2.7.16 on March 4.

Clicking the "Full Changelog" link on the release page gives an April Fool's impression, but further digging finds the useful changelog for 2.7.16rc1.

Summary: They fixed bunch of bugs, mostly crashes from NULL pointers, assertion failures, memory leaks, etc., and added some security fixes.

The Docker build in #521 is adopting Python 2.7.16 since that base container image is readily available (or at least findable). It's best to use the same release everywhere.

@1fish2 1fish2 added code refinement security security vulnerabilities labels Apr 25, 2019
@prismofeverything
Copy link
Member

This is amazing. Python 2 is dead, long live python 2!

@1fish2
Copy link
Contributor Author

1fish2 commented Apr 26, 2019

Looking into exactly what they're promising,

Python 2.7 is the last major release in the 2.x series ...

expected to remain supported by the core development team (receiving security updates and other bug fixes) until at least 2020

while pip warns

DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7.

@1fish2 1fish2 self-assigned this Apr 26, 2019
1fish2 added a commit that referenced this issue Apr 27, 2019
* Fix #525: Update to python 2.7.16 which fixes a bunch of potential crashes, also updating to match the Dockerfile.
* Fix #511 update `urllib3` from 1.23 to 1.24.2 (not to 1.25.1 which is incompatible with this version of requests). https://nvd.nist.gov/vuln/detail/CVE-2019-11324
* Fix #527 update `Jinja2` from 2.10 to 2.10.1. https://nvd.nist.gov/vuln/detail/CVE-2019-10906
* Fix #478 update `pyyaml` from 3.13 to 5.1, which deprecates `yaml.load()` but doesn't actually fix the vulnerability. It looks like they tried to close the execute-arbitrary-code vulnerability in 4.0 but reverted the incompatibility. Still, this update should appease GitHub's security scanner. Change our code to call `yaml.safe_load()` instead of `yaml.load()`, although I think we're calling `ruamel.yaml`. https://nvd.nist.gov/vuln/detail/CVE-2017-18342
* Fix #479 `requests` from 2.19.1 to 2.21.0. It's used by FireWorks, bokeh, confluent_kafka, and ipython. https://nvd.nist.gov/vuln/detail/CVE-2018-18074
* Update `ruamel.yaml` from 0.15.43 to 0.15.94. That's 51 new bug fix releases! Clearly YAML is over-complicated.
* Update NumPy from 1.14.5 to 1.14.6 for a thread safety bug fix. (Releases 1.15 & 1.16 are substantial changes, and 1.17 will drop support for Python 2.7.)
* Add the `typing` and `mypy` pips while we're updating pyenvs. We'll need these when we start adding static type checking.
1fish2 added a commit that referenced this issue May 1, 2019
* Fix #525: Update to python 2.7.16 which fixes a bunch of potential crashes, also updating to match the Dockerfile.
* Fix #511 update `urllib3` from 1.23 to 1.24.2 (not to 1.25.1 which is incompatible with this version of requests). https://nvd.nist.gov/vuln/detail/CVE-2019-11324
* Fix #527 update `Jinja2` from 2.10 to 2.10.1. https://nvd.nist.gov/vuln/detail/CVE-2019-10906
* Fix #478 update `pyyaml` from 3.13 to 5.1, which deprecates `yaml.load()` but doesn't actually fix the vulnerability. It looks like they tried to close the execute-arbitrary-code vulnerability in 4.0 but reverted the incompatibility. Still, this update should appease GitHub's security scanner. Change our code to call `yaml.safe_load()` instead of `yaml.load()`, although I think we're calling `ruamel.yaml`. https://nvd.nist.gov/vuln/detail/CVE-2017-18342
* Fix #479 `requests` from 2.19.1 to 2.21.0. It's used by FireWorks, bokeh, confluent_kafka, and ipython. https://nvd.nist.gov/vuln/detail/CVE-2018-18074
* Update `ruamel.yaml` from 0.15.43 to 0.15.94. That's 51 new bug fix releases! Clearly YAML is over-complicated.
* Update NumPy from 1.14.5 to 1.14.6 for a thread safety bug fix. (Releases 1.15 & 1.16 are substantial changes, and 1.17 will drop support for Python 2.7.)
* Add the `typing` and `mypy` pips while we're updating pyenvs. We'll need these when we start adding static type checking.

## Soon I'll delete and recreate the `wcEcoli2` pyenv.
## Please update the `wcEcoli2` pyenv on your local machines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code refinement security security vulnerabilities
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants