Skip to content
This repository has been archived by the owner on Feb 19, 2021. It is now read-only.

fix a crash on StopExposureNotification() #484

Merged
merged 1 commit into from Jun 20, 2020

Conversation

laiso
Copy link
Contributor

@laiso laiso commented Jun 20, 2020

Purpose

App crashes #450 の修正として提案する変更です。
ExposureNotification が無効な時にExposureNotification.StopAsync() を呼び出さないようにしました。

Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  1. iOSの設定で COVID-19 Exposure Notifications をオフにしてアプリを起動
  2. UserDataChanged 発生
  3. クラッシュ?

What to Check

実際のExposure Notifications APIの試験ができないのでこれで修正ができているのかどうか

@kazumihirose kazumihirose added the bug Something isn't working label Jun 20, 2020
@kazumihirose kazumihirose self-requested a review June 20, 2020 14:33
@kazumihirose
Copy link
Member

ありがとう、ちょうど手が回ってなかったところで、助かります。
こちらでチェックアウトして試してみますね。

@kazumihirose kazumihirose merged commit 33b50c2 into Covid-19Radar:master Jun 20, 2020
kazumihirose added a commit that referenced this pull request Jun 22, 2020
fix a crash on StopExposureNotification()
kazumihirose added a commit that referenced this pull request Jun 22, 2020
fix a crash on StopExposureNotification()
kazumihirose added a commit that referenced this pull request Jun 22, 2020
fix a crash on StopExposureNotification()
kazumihirose added a commit that referenced this pull request Jun 22, 2020
fix a crash on StopExposureNotification()
kazumihirose added a commit that referenced this pull request Jun 22, 2020
fix a crash on StopExposureNotification()
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants