Remove cruft #162
Merged
Remove cruft #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we still need project.pbxproj |
honkfestival
force-pushed
the
remove-cruft
branch
from
80b8a51
to
ee744a6
Compare
|
Double checked — permission library is only pulling in Notification-related stuff, no location APIs referenced. Should be good. |
honkfestival
force-pushed
the
remove-cruft
branch
from
ee744a6
to
6fe2c2b
Compare
gavrix
approved these changes
Jun 25, 2020
I was really confused about how I removed that, but apparently it looks the same in the diff view because the diff is too large. |
lpcox
pushed a commit
to covidsafe/CovidShieldExposure
that referenced
this pull request
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started out removing the
NSLocationWhenInUseUsageDescriptionkey and its related empty string fromInfo.plist. Then to make sure it didn't exist anywhere else, I discovered that it existed in some tvOS files we had, so I removed those (and references to them) too.