Credits

[nathanfallet]

Description

I'm adding a view to show contributors, based on the backend contributors endpoint

Related issue

Fixes #37

What I tested

The view itself

Regression risks

N/A

Screenshots

If applicable, add screenshots to help explain the fix. Otherwise please remove this section

Checklist

• I have installed SwiftLint and made sure code formatting is correct
• I have performed a self-review of my own code
• I tested my changes on real device
• My changes generate no new warnings
• I have commented my code in hard-to-understand areas
• Any dependent changes have been merged into develop
• I have checked there aren't other open Pull Requests for the same update/change

[pylapp]

I tested your credits branch, here are some comments for the feature :)

About the contributors

• For some contributors, we have a pseudonym of the fulll name, some details about contrebutions or not, and an avatar or not. Is it expected?
• How are sorted the contributors? Maybe be should sort them by alphabetic order and by platforms
• For Paul Jannot, an error occurred with it hyperlink. The hyperlink pauljeannot.github.io does not work anymore.
• Same thing for CorentiOS with its hyperlink corentinmedina.fr
• Same thing for Alexandre GUY with its hyperlink www.agraphik.fr
• Same thing for Guillaume Rozier with its hyperlink guillaumerozier.fr

About the UI

• We cannot see easily if we have a clickable cell because an hyperlink is defined, or not.
  Maybe we should add in the contributor cell an image button (containing an SF Symbol) which will redirect the user to the hyperlink target on tap

About a11y

• We may setup a trick for vocalization of "ios" ; maybe convert the word to "iOS" or change the accessible label
• Accessible fonts are not used in this view ; if we use bigger text sizes in device settings, the text size are not changed

Miscellaneous

• Need to rebase your branch from develop :)
• About KingFisher, register this library in the project (licenses folder) and the app (LicenseInfo.plist)
• Some dead code to remove

[pylapp]

@nathanfallet Almost done! The main things to review are about the accessibility (not managed yet in your feature), and also the ordering of the contributors. A bit of dead code too.

[nathanfallet]

For some contributors, we have a pseudonym of the fulll name, some details about contributions or not, and an avatar or not. Is it expected?

Yes. The data is returned by the API at https://vitemadose.gitlab.io/vitemadose/contributors_all.json, so we have no control about it in the app, and for some of them not all data is filled.

Note: I opened this pull request to fix duplicates in the list

For Paul Jannot, an error occurred with it hyperlink. The hyperlink pauljeannot.github.io does not work anymore.
Same thing for CorentiOS with its hyperlink corentinmedina.fr
Same thing for Alexandre GUY with its hyperlink www.agraphik.fr
Same thing for Guillaume Rozier with its hyperlink guillaumerozier.fr

As the data is returned by the API, they need to correct the link where it was fetched from. (I think it was taken from GitHub API, so they need to fix the link in their GitHub profile)

Need to rebase your branch from develop :)

I started the process, it would take too long to do it, with all the changes since the original branch.

About KingFisher, register this library in the project (licenses folder) and the app (LicenseInfo.plist)

I let you work on that, you seemed motivated to, and know how to.

[pylapp]

@nathanfallet I don't have completed this review and refactoring yet, but it's ongoing.
I hope to complete it this night or tomorrow.

I shared to mates the issue about not working hyperlink and doublons in the contributors JSON file.

Here are the things I will do a soon as possible:

• Improve VoiceOver vocalization (hint for ios, hint for hyperlink icons)
• Improve UI if too big text size in use
• Add KingFisher in the project (details in app settings, licence in project)

I keep you in touch !

[pylapp]

Great!