Feature - Maintenance mode #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauljeannot
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #78, we need a maintenance page feature to block the app in ever we face a major issue with the data.
Of course this is very unlikely to happen and should only be used as a last resort.
The page is a simple
UIViewControllerwith an embedded web view that loads a given url. If the url is somehow invalid, we show a local html page as a fallback. Please bear in mind this should never be the case.The logic is driven by a remote config value named
ios_maintenance_mode_url. If the value is not nil nor empty, the page will show up. The empty check on the value is primordial because, if not set, the config default value won't returnnilbut"".Attachments
Closes #78