Revert PR #713 (#744)

This change is causing an untenable amount of noise in log output. Backing out for now. A better solution to the problem of logging service dependency errors is needed. Signed-off-by: The MathWorks, Inc. <jdicleme@mathworks.com>
CppMicroServices · Oct 10, 2022 · 13ca108 · 13ca108
1 parent 22c8387
commit 13ca108
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 173 deletions.
diff --git a/compendium/DeclarativeServices/test/CMakeLists.txt b/compendium/DeclarativeServices/test/CMakeLists.txt
@@ -78,7 +78,6 @@ set(_declarativeservices_tests
   TestRegistrationManager.cpp
   TestSCRBundleExtension.cpp
   TestServiceComponentRuntimeImpl.cpp
-  TestServiceDependencyErrorLogging.cpp
   TestServiceMetadataParserV1.cpp
   TestSetConfiguration.cpp
   TestSingletonComponentConfiguration.cpp

diff --git a/compendium/DeclarativeServices/test/TestServiceDependencyErrorLogging.cpp b/compendium/DeclarativeServices/test/TestServiceDependencyErrorLogging.cpp
diff --git a/framework/src/service/ServiceListeners.cpp b/framework/src/service/ServiceListeners.cpp
@@ -446,23 +446,6 @@ void ServiceListeners::GetMatchingServiceListeners(const ServiceEvent& evt,
       const LDAPExpr& ldapExpr = sse.GetLDAPExpr();
       if (ldapExpr.IsNull() || ldapExpr.Evaluate(props, false)) {
         set.insert(sse);
-      } else if (evt.GetType() == ServiceEvent::SERVICE_REGISTERED) {
-        // get the props key and value for logging
-        std::string propsKeyValues{};
-
-        auto key = props->Keys_unlocked();
-        for (auto k : key) {
-          auto val = props->Value_unlocked(k).first.ToString();
-          propsKeyValues += k + " : " + val + ", ";
-        }
-
-        const std::string msg =
-          "Service listener matching LDAP filter could "
-          "not be found using LDAP filter: " +
-          sse.GetFilter() + ". Please verify the LDAP filter value in service properties: " + "{" + propsKeyValues + "}";
-
-          coreCtx->logger->Log(
-            cppmicroservices::logservice::SeverityLevel::LOG_DEBUG, msg);
       }
     }