Removing std::move use with const object [ci skip] (#848)

* Removing std::move use with const [ci skip] Signed-off-by: Tahar Touati <touati.thr@gmail.com> * Addressing PR feedback, removing const from complex types and adding std move back [ci skip] Signed-off-by: Tahar Touati <touati.thr@gmail.com> --------- Signed-off-by: Tahar Touati <touati.thr@gmail.com>
CppMicroServices · May 8, 2023 · 3f2a461 · 3f2a461
1 parent 6df4810
commit 3f2a461
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/compendium/CM/include/cppmicroservices/cm/ConfigurationListener.hpp b/compendium/CM/include/cppmicroservices/cm/ConfigurationListener.hpp
@@ -58,10 +58,10 @@ namespace cppmicroservices
             class ConfigurationEvent
             {
               public:
-                ConfigurationEvent(ServiceReference<ConfigurationAdmin> const configAdmin,
+                ConfigurationEvent(ServiceReference<ConfigurationAdmin> configAdmin,
                                    const ConfigurationEventType type,
-                                   const std::string factoryPid,
-                                   const std::string pid)
+                                   std::string factoryPid,
+                                   std::string pid)
                     : configAdmin(std::move(configAdmin))
                     , type(type)
                     , factoryPid(std::move(factoryPid))

diff --git a/compendium/DeclarativeServices/src/manager/ComponentConfigurationImpl.hpp b/compendium/DeclarativeServices/src/manager/ComponentConfigurationImpl.hpp
@@ -56,7 +56,7 @@ namespace cppmicroservices
         {
             ListenerToken(std::string pid, const ListenerTokenId tokenId)
                 : pid(std::move(pid))
-                , tokenId(std::move(tokenId))
+                , tokenId(tokenId)
             {
             }
             std::string pid;