Cleaned up some security warnings (#700)

Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>

framework/include/cppmicroservices/Any.h

@@ -407,7 +407,7 @@ class US_Framework_EXPORT Any
    * \param rhs The Any which should be moved into this Any.
    * \return A reference to this Any.
    */
-  Any& operator=(Any&& rhs)
+  Any& operator=(Any&& rhs) noexcept
   {
     _content = std::move(rhs._content);
     return *this;

framework/include/cppmicroservices/Bundle.h

@@ -240,10 +240,10 @@ class US_Framework_EXPORT Bundle
     STOP_TRANSIENT = 0x00000001
   };
 
-  Bundle(const Bundle&);            // = default
-  Bundle(Bundle&&);                 // = default
-  Bundle& operator=(const Bundle&); // = default
-  Bundle& operator=(Bundle&&);      // = default
+  Bundle(const Bundle&);                // = default
+  Bundle(Bundle&&) noexcept;            // = default
+  Bundle& operator=(const Bundle&);     // = default
+  Bundle& operator=(Bundle&&) noexcept; // = default
 
   /**
    * Constructs an invalid %Bundle object.

framework/include/cppmicroservices/Framework.h

@@ -73,10 +73,10 @@ class US_Framework_EXPORT Framework : public Bundle
      */
   explicit Framework(Bundle b);
 
-  Framework(const Framework& fw);            // = default
-  Framework(Framework&& fw);                 // = default
-  Framework& operator=(const Framework& fw); // = default
-  Framework& operator=(Framework&& fw);      // = default
+  Framework(const Framework& fw);                // = default
+  Framework(Framework&& fw) noexcept;            // = default
+  Framework& operator=(const Framework& fw);     // = default
+  Framework& operator=(Framework&& fw) noexcept; // = default
 
   /**
      * Initialize this Framework. After calling this method, this Framework

framework/include/cppmicroservices/ListenerToken.h

@@ -51,9 +51,9 @@ class US_Framework_EXPORT ListenerToken
 
   ListenerToken& operator=(const ListenerToken&) = delete;
 
-  ListenerToken(ListenerToken&& other);
+  ListenerToken(ListenerToken&& other) noexcept;
 
-  ListenerToken& operator=(ListenerToken&& other);
+  ListenerToken& operator=(ListenerToken&& other) noexcept;
 
   /**
      * Tests this %ListenerToken object for validity.

framework/include/cppmicroservices/ServiceObjects.h

@@ -42,8 +42,8 @@ class US_Framework_EXPORT ServiceObjectsBase
   ServiceObjectsBase(const ServiceObjectsBase& other) = delete;
   ServiceObjectsBase& operator=(const ServiceObjectsBase& other) = delete;
 
-  ServiceObjectsBase(ServiceObjectsBase&& other);
-  ServiceObjectsBase& operator=(ServiceObjectsBase&& other);
+  ServiceObjectsBase(ServiceObjectsBase&& other) noexcept;
+  ServiceObjectsBase& operator=(ServiceObjectsBase&& other) noexcept;
 
 protected:
   ServiceObjectsBase(const std::shared_ptr<BundleContextPrivate>& context,
@@ -177,8 +177,8 @@ class US_Framework_EXPORT ServiceObjects<void> : private ServiceObjectsBase
   ServiceObjects(const ServiceObjects& other) = delete;
   ServiceObjects& operator=(const ServiceObjects& other) = delete;
 
-  ServiceObjects(ServiceObjects&& other);
-  ServiceObjects& operator=(ServiceObjects&& other);
+  ServiceObjects(ServiceObjects&& other) noexcept;
+  ServiceObjects& operator=(ServiceObjects&& other) noexcept;
 
   /**
    * Returns a service object as a InterfaceMap instance for the referenced service.

framework/include/cppmicroservices/ServiceRegistrationBase.h

@@ -61,7 +61,7 @@ class US_Framework_EXPORT ServiceRegistrationBase
 public:
   ServiceRegistrationBase(const ServiceRegistrationBase& reg);
 
-  ServiceRegistrationBase(ServiceRegistrationBase&& reg);
+  ServiceRegistrationBase(ServiceRegistrationBase&& reg) noexcept;
 
   /**
    * A boolean conversion operator converting this ServiceRegistrationBase object
@@ -178,7 +178,7 @@ class US_Framework_EXPORT ServiceRegistrationBase
 
   ServiceRegistrationBase& operator=(
     const ServiceRegistrationBase& registration);
-  ServiceRegistrationBase& operator=(ServiceRegistrationBase&& registration);
+  ServiceRegistrationBase& operator=(ServiceRegistrationBase&& registration) noexcept;
 
 private:
   friend class ServiceRegistry;

framework/include/cppmicroservices/detail/Threads.h

@@ -62,7 +62,7 @@ class MutexLockingStrategy
 
 #ifdef US_ENABLE_THREADING_SUPPORT
 
-    UniqueLock(UniqueLock&& o)
+    UniqueLock(UniqueLock&& o) noexcept
       : m_Lock(std::move(o.m_Lock))
     {}
 

framework/src/bundle/Bundle.cpp

@@ -44,14 +44,14 @@ namespace cppmicroservices {
 
 Bundle::Bundle(const Bundle&) = default;
 
-Bundle::Bundle(Bundle&& b)
+Bundle::Bundle(Bundle&& b) noexcept
   : d(std::move(b.d))
   , c(std::move(b.c))
 {}
 
 Bundle& Bundle::operator=(const Bundle&) = default;
 
-Bundle& Bundle::operator=(Bundle&& b)
+Bundle& Bundle::operator=(Bundle&& b) noexcept
 {
   this->d = std::move(b.d);
   this->c = std::move(b.c);

framework/src/service/ListenerToken.cpp

@@ -34,13 +34,13 @@ ListenerToken::ListenerToken(ListenerTokenId _tokenId)
   : tokenId(_tokenId)
 {}
 
-ListenerToken::ListenerToken(ListenerToken&& other)
+ListenerToken::ListenerToken(ListenerToken&& other) noexcept
   : tokenId(std::move(other.tokenId))
 {
   other.tokenId = ListenerTokenId(0);
 }
 
-ListenerToken& ListenerToken::operator=(ListenerToken&& other)
+ListenerToken& ListenerToken::operator=(ListenerToken&& other) noexcept
 {
   tokenId = std::move(other.tokenId);
   other.tokenId = ListenerTokenId(0);

framework/src/service/ServiceObjects.cpp

@@ -185,23 +185,23 @@ ServiceReferenceBase ServiceObjectsBase::GetReference() const
   return d->m_reference;
 }
 
-ServiceObjectsBase::ServiceObjectsBase(ServiceObjectsBase&& other)
+ServiceObjectsBase::ServiceObjectsBase(ServiceObjectsBase&& other) noexcept
   : d(std::move(other.d))
 {}
 
 ServiceObjectsBase::~ServiceObjectsBase() = default;
 
-ServiceObjectsBase& ServiceObjectsBase::operator=(ServiceObjectsBase&& other)
+ServiceObjectsBase& ServiceObjectsBase::operator=(ServiceObjectsBase&& other) noexcept
 {
   d = std::move(other.d);
   return *this;
 }
 
-ServiceObjects<void>::ServiceObjects(ServiceObjects&& other)
+ServiceObjects<void>::ServiceObjects(ServiceObjects&& other) noexcept
   : ServiceObjectsBase(std::move(other))
 {}
 
-ServiceObjects<void>& ServiceObjects<void>::operator=(ServiceObjects&& other)
+ServiceObjects<void>& ServiceObjects<void>::operator=(ServiceObjects&& other) noexcept
 {
   ServiceObjectsBase::operator=(std::move(other));
   return *this;

framework/src/service/ServiceRegistrationBase.cpp

@@ -49,7 +49,7 @@ ServiceRegistrationBase::ServiceRegistrationBase(
     ++d->ref;
 }
 
-ServiceRegistrationBase::ServiceRegistrationBase(ServiceRegistrationBase&& reg)
+ServiceRegistrationBase::ServiceRegistrationBase(ServiceRegistrationBase&& reg) noexcept
   : d(nullptr)
 {
   std::swap(d, reg.d);
@@ -353,7 +353,7 @@ ServiceRegistrationBase& ServiceRegistrationBase::operator=(
 }
 
 ServiceRegistrationBase& ServiceRegistrationBase::operator=(
-  ServiceRegistrationBase&& registration)
+  ServiceRegistrationBase&& registration) noexcept
 {
   if (d && !--d->ref)
     delete d;

framework/src/util/Framework.cpp

@@ -38,13 +38,13 @@ FrameworkPrivate* pimpl(const std::shared_ptr<BundlePrivate>& p)
 
 Framework::Framework(const Framework&) = default;
 
-Framework::Framework(Framework&& fw)
+Framework::Framework(Framework&& fw) noexcept
   : Bundle(std::move(fw))
 {}
 
 Framework& Framework::operator=(const Framework&) = default;
 
-Framework& Framework::operator=(Framework&& fw)
+Framework& Framework::operator=(Framework&& fw) noexcept
 {
   Bundle::operator=(std::move(fw));
   return *this;

framework/src/util/Properties.cpp

@@ -58,12 +58,12 @@ Properties::Properties(const AnyMap& p)
   }
 }
 
-Properties::Properties(Properties&& o)
+Properties::Properties(Properties&& o) noexcept
   : keys(std::move(o.keys))
   , values(std::move(o.values))
 {}
 
-Properties& Properties::operator=(Properties&& o)
+Properties& Properties::operator=(Properties&& o) noexcept
 {
   keys = std::move(o.keys);
   values = std::move(o.values);

framework/src/util/Properties.h

@@ -38,8 +38,8 @@ class Properties : public detail::MultiThreaded<>
 public:
   explicit Properties(const AnyMap& props);
 
-  Properties(Properties&& o);
-  Properties& operator=(Properties&& o);
+  Properties(Properties&& o) noexcept;
+  Properties& operator=(Properties&& o) noexcept;
 
   Any Value_unlocked(const std::string& key) const;
   Any Value_unlocked(int index) const;
@@ -66,7 +66,7 @@ class PropertiesHandle
     , l(lock ? props.Lock() : Properties::UniqueLock())
   {}
 
-  PropertiesHandle(PropertiesHandle&& o)
+  PropertiesHandle(PropertiesHandle&& o) noexcept
     : props(o.props)
     , l(std::move(o.l))
   {}