Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDAP filters lack support for boolean properties during creation #224

Closed
saschazelzer opened this issue Jul 28, 2017 · 0 comments
Closed

LDAP filters lack support for boolean properties during creation #224

saschazelzer opened this issue Jul 28, 2017 · 0 comments
Assignees
@saschazelzer
Projects
Release 3.2

Comments

@saschazelzer
Copy link
Member

The LDAPProp class contains operator== overloads for a few types, but does not provide an overload for bool. So instead of being able to write

LDAPProp("prop") == false

one has to write

LDAPProp("prop") == std::string("false")

A proper operator==(bool) overload should be added instead.
@saschazelzer saschazelzer self-assigned this Jul 28, 2017
@saschazelzer saschazelzer added this to Planned in Release 3.2 Jul 30, 2017
@saschazelzer saschazelzer moved this from Planned to In Progress in Release 3.2 Jul 30, 2017
saschazelzer added a commit that referenced this issue Aug 18, 2017
@saschazelzer
Merge pull request #229 from CppMicroServices/224-ldap-boolean-prop-s…
d03cfca 
…upport

Support boolean properties in LDAP filter creation. Fixes #224.
@jeffdiclemente jeffdiclemente moved this from In Progress to Done in Release 3.2 Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saschazelzer saschazelzer

Labels
None yet
Projects
No open projects
Release 3.2
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saschazelzer