LDAP API improvements

[jeffdiclemente]

Use Case

I want to construct long LDAP expressions and conditionally modify them using concise modern C++.

Pain Point

LDAP expressions can be conditionally built however it requires more code than is necessary...

LDAPFilter filter(LDAPProp("key1") == "value1");

if (someCondition) {
    filter = LDAPFilter(LDAPPropExpr(filter.ToString()) || LDAPProp("key2") == "value2");
} else {
    filter = LDAPFilter(LDAPPropExpr(filter.ToString()) || LDAPProp("key3") == "value3");
}

This is not only more code to write for clients, its also wasteful since extra temporary objects need to be created.

Solution

• Make LDAPPropExpr::operator= and LDAPProp::operator= public.
• Implement LDAPProp::operator|= andLDAPProp::operator&=

This allows the following to be written...

LDAPPropExpr expr(LDAPProp("key1") == "value1");

if (someCondition) {
    expr = expr || LDAPProp("key2") == "value2"; // or even more conveniently, expr |= LDAPProp("key2") == "value2";
} else {
    expr = expr || LDAPProp("key3") == "value3";
}

And even more concisely...

LDAPPropExpr expr(LDAPProp("key1") == "value1");

if (someCondition) {
    expr |= LDAPProp("key2") == "value2";
} else {
    expr |= LDAPProp("key3") == "value3";
}