-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose checksum from zip archive. #307
Comments
Here's what I was thinking, using 'uint32_t' for the type, and 'GetCrc32' for the method name. |
Thanks Charles. The motivation and the changes you made in your feature branch look fine to me. I am awaiting feedback from other core developers. |
@mw-cwilcox looks good to me. please go ahead and issue a PR to the CppMicroServices development branch. If you could also add the contents of this issue as a RFC, using the process in https://github.com/CppMicroServices/rfcs, that would be very helpful. Thanks! |
Krish and Jeff, I've created the PR #308. Let me know if you need any other information. Thanks! |
Fixed in #308 |
I'm requesting an enhancement, to expose a checksum of the bundle data.
Motivation
My team is using CppMicroServices in deployment where DLLs may be loaded, unloaded, and reloaded through the process lifetime, and would like to utilize a checksum to know if a bundle has changed from a prior load. There is already a 'crc32' in the zip-data, so this seems straightforward to implement.
Approach
Branch
I intend to prototype exactly what I described here on a fork in a feature branch.
The text was updated successfully, but these errors were encountered: